Review main Merged

63698[BUGFIX] Install Tool modals won't depend on spinner

Andreas Kienast CR +2 V +2 Easy +14 −15 updated 03/13/20, 12:17

Commit message

The Install Tool modals now fire up immediately after requesting a
module. The spinners are now loaded in parallel and don't block the
rendering of the modals anymore.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 03/12/20, 21:28

  2. Andreas Kienast uploaded patch set 2 03/12/20, 21:30

  3. Andreas Kienast wrote 03/12/20, 21:31

    Topic set to install tool
  4. TYPO3com voted on patch set 1 V +1 03/12/20, 21:45 Completed build in 16m 11s on Thu, 12 Mar, 09:45 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1299

  5. Markus Klein commented on patch set 2 V +1 CR +1 03/12/20, 21:50

    seems to work flawlessly
  6. TYPO3com voted on patch set 2 V +1 03/12/20, 21:51 Completed build in 15m 33s on Thu, 12 Mar, 09:51 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1300

  7. Frank Nägler voted on patch set 2 CR +1 03/13/20, 12:15

  8. Frank Nägler voted on patch set 2 V +2 CR +2 03/13/20, 12:17

  9. Frank Nägler merged patch set 3 03/13/20, 12:17