Review main Abandoned

63699[BUGFIX] Make DB compare correct again for SQLite

Markus Klein CR 0 V 0 Hard +7 −846 updated 03/13/20, 19:13

Commit message

SQLite can handle primary key.
But field names need to be quoted!

Remove a lot of duplicate tests for SQLite as well.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1321

  1. Markus Klein uploaded patch set 1 03/12/20, 22:45

  2. TYPO3com voted on patch set 1 V -1 03/12/20, 22:56 Completed build in 11m 13s on Thu, 12 Mar, 10:56 PM Test Summary: 3049 of 72368 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1304

  3. Markus Klein uploaded patch set 2 03/12/20, 23:09

  4. Markus Klein marked it work in progress 03/12/20, 23:10

  5. Markus Klein updated the commit message in patch set 3 03/12/20, 23:22

  6. TYPO3com voted on patch set 2 V -1 03/12/20, 23:29 Completed build in 19m 18s on Thu, 12 Mar, 11:29 PM Test Summary: 3035 of 72673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1306

  7. TYPO3com voted on patch set 3 V -1 03/12/20, 23:39 Completed build in 17m 11s on Thu, 12 Mar, 11:39 PM Test Summary: 3035 of 72673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1307

  8. Markus Klein uploaded patch set 4 03/12/20, 23:42

  9. Markus Klein uploaded patch set 5 03/12/20, 23:55

  10. Markus Klein commented on patch set 5 03/12/20, 23:56

    This change is ready for review.
  11. TYPO3com voted on patch set 4 V -1 03/13/20, 00:01 Completed build in 18m 52s on Fri, 13 Mar, 12:01 AM Test Summary: 30 of 72673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1308

  12. Markus Klein uploaded patch set 6 03/13/20, 00:06

  13. TYPO3com voted on patch set 5 V -1 03/13/20, 00:11 Completed build in 15m 55s on Fri, 13 Mar, 12:11 AM Test Summary: 2 of 72673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1309

  14. TYPO3com voted on patch set 6 V +1 03/13/20, 00:21 Completed build in 14m 19s on Fri, 13 Mar, 12:21 AM Test Summary: 71955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1310

  15. Andreas Kienast voted on patch set 6 CR +1 03/13/20, 07:17

  16. Daniel Goerz commented on patch set 6 V +1 CR +1 03/13/20, 08:33

    Verified by trusting bamboo ...
  17. Markus Klein rebased onto patch set 7 03/13/20, 16:59

  18. Markus Klein rebased onto patch set 8 03/13/20, 17:03

  19. TYPO3com voted on patch set 7 V +1 03/13/20, 17:17 Completed build in 17m 50s on Fri, 13 Mar, 05:17 PM Test Summary: 71955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1320

  20. TYPO3com voted on patch set 8 V +1 03/13/20, 17:29 Completed build in 18m 26s on Fri, 13 Mar, 05:29 PM Test Summary: 71955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1323

  21. Markus Klein abandoned the change 03/13/20, 19:13