Review TYPO3_4-5 Merged

6370[BUGFIX] Multiple values not displayed for simple items lists

Francois Suter CR +2 V +2 Easy +36 −2 updated 06/03/13, 20:49

Commit message

t3lib_BEfunc::getProcessedValue() is used throughout the Core to
transform values stored as indices into human-readable values.

However for select-type fields based on a list of items
(and not a foreign table) where multiple selections are possible,
t3lib_BEfunc::getProcessedValue() fails to display anything.
This is due to t3lib_BEfunc::getLabelFromItemlist(),
being unable to handle several values.

This patch introduces a new method to avoid breaking compatibility.

Review

  • Code review CR +2
    • Francois Suter +2
    • Georg Ringer +1
    • Michael Stucki +1
  • Verified V +2
    • Francois Suter +2
    • Georg Ringer +1
    • Michael Stucki +1

Issues 1

Files 1

Review log 9

  1. Michael Stucki commented on patch set 2 11/22/11, 07:51

    Verified; Looks good to me, but someone else must approve So Xavier asked to reply here instead in the change for the master branch... That's indeed a nice improvement! :-) I think this certainly qualifies as a bugfix even though it adds a new function... I was thinking for a while if the function should be called "..fromItemList" or "..fromItemsList". However, after giving it some thought I think that your wording is fine. One more note though: Unfortunately the value of $fixed_lgd_chars is sometimes hardcoded to 100, which may result in a stripped output again. However, this is something that needs to be address by a separate change... Anyway, thanks for your proposal, I like it and confirm it works! :-)
  2. Francois Suter commented on patch set 2 V 0 11/22/11, 07:51

    by team member; Looks good to me, approved Thanks for the reviews. I'll forward-port the corrected patch to the higher branches. Sorry for the confusion in the submission process.
  3. Francois Suter commented on patch set 2 11/22/11, 07:51

    Patch 2 corrects the ident errors. Bring on the more constructive remarks ;-)
  4. Francois Suter uploaded patch set 2 11/22/11, 07:51

  5. Xavier Perseguers commented on patch set 1 11/22/11, 07:51

    (4 inline comments)
    Typo here: "Multiple"

    class.t3lib_befunc.php:2135

    Invalid indent of the comment

    class.t3lib_befunc.php:2144

    Same here. Spaces instead of tabs?

    class.t3lib_befunc.php:2385

    Wrong indent.
  6. Georg Ringer commented on patch set 2 11/22/11, 07:51

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 11/22/11, 07:51

  8. Mr. Jenkins commented on patch set 2 11/22/11, 07:51

  9. Francois Suter merged patch set 2 11/22/11, 07:51