63700[BUGFIX] Make DateViewHelperTests resilient to execution time
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Markus Klein uploaded patch set 1 03/13/20, 00:17
-
TYPO3com voted on patch set 1 V +1 03/13/20, 00:38 Completed build in 21m 11s on Fri, 13 Mar, 12:38 AM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1311
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/13/20, 06:30
-
Mathias Brodala commented on patch set 1 03/13/20, 07:39
-
Markus Klein commented on patch set 1 03/13/20, 08:26
DateViewHelperTest.php:151ReplyI consider EXEC_TIME also kind of future-proof. 1) it is simple 2) time is global by definition 3) changing this is a huge thing anyway, so it wouldn't matter to touch one more place. -
Markus Klein rebased onto patch set 2 03/13/20, 17:04
-
TYPO3com voted on patch set 2 V +1 03/13/20, 17:43 Completed build in 32m 08s on Fri, 13 Mar, 05:43 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1326
-
Georg Ringer voted on patch set 2 V +1 CR +1 03/14/20, 18:44
-
Susi Moog commented on patch set 2 V +2 CR +2 03/15/20, 08:08
DateViewHelperTest.php:151Reply Unresolvedbasically: Mathias is right in the long run. We want to get rid of the globals used (see the usage of the context in the view helper you are testing here) and allow cleanly manipulating the content. However, in this case I'd agree that this would be a bigger change and should probably done at once for all occurences of EXEC_TIME (and ACCESS_TIME if any) that are left - and not in v10. so, let's merge this one like it is. -
Susi Moog merged patch set 3 03/15/20, 08:08
DateViewHelperTest.php:151