Review main Abandoned

63712[BUGFIX] Allow only one column operation per table in sqlite

Markus Klein CR 0 V 0 Easy +27 −2 updated 03/16/20, 08:05

Commit message

This prevents the generation of wrong migration SQL statements.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 911

  1. Markus Klein uploaded patch set 1 03/13/20, 16:59

  2. Mathias Brodala commented on patch set 1 03/13/20, 17:01

    Just to get it right: this means that I'd need to run schema updates multiple times for SQLite? That'd be rather unusual and confusing and make it impossible to combine with automated deployments.
  3. Markus Klein rebased onto patch set 2 03/13/20, 17:03

  4. TYPO3com voted on patch set 1 V +1 03/13/20, 17:20 Completed build in 20m 55s on Fri, 13 Mar, 05:20 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1321

  5. TYPO3com commented on patch set 2 03/13/20, 17:39 Completed build in 28m 12s on Fri, 13 Mar, 05:39 PM Test Summary: 72195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1325

  6. Markus Klein commented on patch set 2 03/13/20, 18:46

    > Patch Set 1: > > Just to get it right: this means that I'd need to run schema updates multiple times for SQLite? That'd be rather unusual and confusing and make it impossible to combine with automated deployments. Yes correct. The other option (as listed in the ticket) would be to always migrate all fields of a table at once.
  7. Markus Klein commented on patch set 2 03/13/20, 18:48

    > Patch Set 1: > > Just to get it right: this means that I'd need to run schema updates multiple times for SQLite? That'd be rather unusual and confusing and make it impossible to combine with automated deployments. Renaming and deleting fields (tables) is usually not something we have automated. you can still run the command in a loop until there is nothing left to do.
  8. Markus Klein uploaded patch set 3 03/13/20, 19:02

  9. Markus Klein abandoned the change 03/13/20, 19:13

  10. Mathias Brodala commented on patch set 3 03/16/20, 07:51

    > Patch Set 2: > > > Patch Set 1: > > > > Just to get it right: this means that I'd need to run schema updates multiple times for SQLite? That'd be rather unusual and confusing and make it impossible to combine with automated deployments. > > Renaming and deleting fields (tables) is usually not something we have automated. you can still run the command in a loop until there is nothing left to do. Sure, but how to detect this? Unless there is some kind of information via exit code aside from 0, you cannot do anything about this via CLI.
  11. Markus Klein commented on patch set 3 03/16/20, 08:05

    > Patch Set 3: > > > Patch Set 2: > > > > > Patch Set 1: > > > > > > Just to get it right: this means that I'd need to run schema updates multiple times for SQLite? That'd be rather unusual and confusing and make it impossible to combine with automated deployments. > > > > Renaming and deleting fields (tables) is usually not something we have automated. you can still run the command in a loop until there is nothing left to do. > > Sure, but how to detect this? Unless there is some kind of information via exit code aside from 0, you cannot do anything about this via CLI. `grep` the output. There is dedicated output if there is nothing left to do.