Review main Merged

63714[BUGFIX] Handle docroot-relative paths in ResourceCompressor

Markus Klein CR +2 V +2 Normal +66 −4 updated 03/19/20, 11:09

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 2538

Show 813 earlier messages
  1. Markus Klein uploaded patch set 1 03/13/20, 19:53

  2. TYPO3com voted on patch set 1 V -1 03/13/20, 19:54 Completed build in 22s on Fri, 13 Mar, 07:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1330

  3. Markus Klein commented on patch set 1 V -1 CR -1 03/13/20, 20:08

    will rework this thing
  4. Markus Klein uploaded patch set 2 03/13/20, 20:23

  5. Markus Klein updated the commit message in patch set 3 03/13/20, 20:25

  6. Markus Klein commented on patch set 3 CR -1 03/13/20, 20:37

    I'm searching for a better solution
  7. TYPO3com voted on patch set 2 V +1 03/13/20, 20:40 Completed build in 17m 00s on Fri, 13 Mar, 08:40 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1331

  8. Markus Klein uploaded patch set 4 03/13/20, 20:47

  9. Markus Klein updated the commit message in patch set 5 03/13/20, 20:47

  10. TYPO3com voted on patch set 3 V +1 03/13/20, 20:53 Completed build in 22m 45s on Fri, 13 Mar, 08:53 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1332

  11. TYPO3com voted on patch set 4 V +1 03/13/20, 21:18 Completed build in 19m 39s on Fri, 13 Mar, 09:18 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1337

  12. TYPO3com voted on patch set 5 V +1 03/13/20, 21:22 Completed build in 23m 49s on Fri, 13 Mar, 09:22 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1338

  13. Oliver Klee commented on patch set 5 03/14/20, 10:25

    Can we cover this with tests?
  1. Georg Ringer voted on patch set 5 V +1 CR +1 03/14/20, 19:35

  2. Susi Moog commented on patch set 5 CR -1 03/15/20, 08:00

    Please add tests - we have pre-existing scenarios you can extend: - getFilenamesFromMainDirInBackendContext - getFilenamesFromMainDirInFrontendContext
  3. Markus Klein commented on patch set 5 03/16/20, 08:07

    > Patch Set 5: Code-Review-1 > > Please add tests - we have pre-existing scenarios you can extend: > - getFilenamesFromMainDirInBackendContext > - getFilenamesFromMainDirInFrontendContext I tried to, but failed "simulating" that the instance is in a subfolder of docroot. All current tests rely on really existing assets for the is_file() checks. We can't do that for the case here, where the instance shall be in a subfolder.
  4. Susi Moog uploaded patch set 6 03/19/20, 07:05

  5. TYPO3com voted on patch set 6 V -1 03/19/20, 07:05 Completed build in 21s on Thu, 19 Mar, 07:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1425

  6. Andreas Kienast uploaded patch set 7 03/19/20, 07:12

  7. TYPO3com voted on patch set 7 V -1 03/19/20, 07:24 Completed build in 11m 53s on Thu, 19 Mar, 07:24 AM Test Summary: 6 of 72592 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1426

  8. Markus Klein commented on patch set 8 03/19/20, 07:39

    Published edit on patch set 7.
  9. TYPO3com voted on patch set 8 V -1 03/19/20, 07:53 Completed build in 13m 07s on Thu, 19 Mar, 07:53 AM Test Summary: 6 of 72592 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1428

  10. Susi Moog uploaded patch set 9 03/19/20, 08:14

  11. TYPO3com voted on patch set 9 V -1 03/19/20, 08:15 Completed build in 22s on Thu, 19 Mar, 08:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1429

  12. Susi Moog uploaded patch set 10 03/19/20, 08:17

  13. TYPO3com voted on patch set 10 V -1 03/19/20, 08:29 Completed build in 11m 47s on Thu, 19 Mar, 08:29 AM Test Summary: 6 of 72592 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1430

  14. Susi Moog uploaded patch set 11 03/19/20, 08:37

  15. Susi Moog uploaded patch set 12 03/19/20, 08:39

  16. Susi Moog uploaded patch set 13 03/19/20, 08:46

  17. TYPO3com voted on patch set 13 V -1 03/19/20, 08:47 Completed build in 24s on Thu, 19 Mar, 08:47 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1433

  18. Susi Moog uploaded patch set 14 03/19/20, 08:50

  19. TYPO3com voted on patch set 12 V -1 03/19/20, 08:51 Completed build in 11m 23s on Thu, 19 Mar, 08:51 AM Test Summary: 6 of 72079 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1432

  20. TYPO3com voted on patch set 14 V +1 03/19/20, 09:11 Completed build in 20m 48s on Thu, 19 Mar, 09:11 AM Test Summary: 72106 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1434

  21. Susi Moog commented on patch set 14 V +1 CR +1 03/19/20, 09:14

    that was surprisingly annoying ;) finally green.
  22. Andreas Kienast voted on patch set 14 CR +1 03/19/20, 09:19

  23. Oliver Klee voted on patch set 14 CR +1 03/19/20, 11:04

  24. Benni Mack voted on patch set 14 V +2 CR +2 03/19/20, 11:09

  25. Benni Mack merged patch set 15 03/19/20, 11:09