Review main Abandoned

63716[WIP][TASK] Introduce item sorting component

Oliver Hader CR 0 V 0 Expert +1014 −0 updated 03/28/20, 08:37

Commit message

* goal: extract DataHandler sorting
* decouple database invocation from sorting
* introduce arbitrary sorting partitions

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 58

  1. Oliver Hader uploaded patch set 1 03/13/20, 20:41

  2. Oliver Hader uploaded patch set 2 03/13/20, 20:41

  3. TYPO3com voted on patch set 1 V -1 03/13/20, 20:44 Completed build in 30s on Fri, 13 Mar, 08:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1334

  4. TYPO3com voted on patch set 2 V +1 03/13/20, 21:08 Completed build in 23m 54s on Fri, 13 Mar, 09:08 PM Test Summary: 72207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1335

  5. Oliver Hader uploaded patch set 3 03/14/20, 00:12

  6. TYPO3com voted on patch set 3 V +1 03/14/20, 00:31 Completed build in 18m 59s on Sat, 14 Mar, 12:31 AM Test Summary: 72213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1340

  7. Oliver Hader uploaded patch set 4 03/28/20, 08:34

  8. Oliver Hader abandoned the change 03/28/20, 08:37

    Unfortunately the initial plan does not work out with the current architecture in TYPO3 v10. * actions (insert, update, move, ...) have to be streamlined to process data before actually being written - currently sorting values are applied in v10 spontanously when the data/record is about to be processed and persisted immediately * having a collection allows to "get an overview" about what would actually happen (before persisting) * for the time being: bugfixes have to be applied to the current sorting mechanisms in DataHandler directly...