63718[TASK] Move Dashboard out of web
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
- Benjamin Kott +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
- Riccardo De Contardi +1
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 32
- Build/Sources/Sass/scaffold/_modulemenu.scss+165 −98
- Build/Sources/Sass/scaffold/_scaffold.scss+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+30 −21
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+7 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Model/Module/BackendModule.php+23 −0
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+7 −3
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+1 −3
- typo3/sysext/backend/Resources/Private/Templates/ModuleMenu/Main.html1+42 −35
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+24 −20
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html+19 −16
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/GetExtensionsCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/CategoryTreeCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/General/ModuleMenuCest.php+15 −15
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Scheduler/TasksCest.php+2 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/ModuleMenuButtonCest.php+13 −13
Show 12 more files
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/IntroductionPackageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/IntroductionPackageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/IntroductionPackageCest.php+1 −1
- typo3/sysext/dashboard/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/dashboard/ext_localconf.php+1 −1
- typo3/sysext/dashboard/ext_tables.php2+4 −3
- typo3/sysext/install/Resources/Private/Partials/Layout/MenuModuleLink.html+19 −14
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html+33 −48
- typo3/sysext/install/Resources/Public/JavaScript/Router.js+1 −1
Review log 3140
Show 1315 earlier messages
-
Susi Moog uploaded patch set 1 03/14/20, 11:16
-
Richard Haeser commented on patch set 1 03/14/20, 12:57
ext_tables.php:16UnresolvedThere are some more places we have to change this. For example in the ext_localconf to set the default startModule. Not for now, but just so we don't forget.ext_tables.php:25UnresolvedCan we prevent this rearranging of the array? Or would that be a breaking change? -
Susi Moog uploaded patch set 2 03/23/20, 09:47
-
Susi Moog uploaded patch set 3 03/23/20, 09:48
-
Richard Haeser commented on patch set 3 03/23/20, 10:13
Styling wise some changes are needed, but code sie this is ok if you ask me -
Benjamin Kott uploaded patch set 4 03/27/20, 09:41
-
Benjamin Kott uploaded patch set 5 03/27/20, 09:45
-
Benjamin Kott uploaded patch set 6 03/27/20, 13:11
-
Benjamin Kott uploaded patch set 7 03/27/20, 14:08
-
Susi Moog marked it work in progress 03/27/20, 14:10
-
Susi Moog wrote 03/27/20, 14:10
Unset private -
Susi Moog rebased onto patch set 8 03/27/20, 14:10
-
TYPO3com voted on patch set 8 V -1 03/27/20, 14:11 Completed build in 31s on Fri, 27 Mar, 02:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1846
-
Benjamin Kott uploaded patch set 9 03/27/20, 14:16
-
TYPO3com voted on patch set 9 V -1 03/27/20, 14:28 Completed build in 11m 52s on Fri, 27 Mar, 02:28 PM Test Summary: 18 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1847
-
Benjamin Kott uploaded patch set 10 03/27/20, 14:31
-
TYPO3com voted on patch set 10 V -1 03/27/20, 14:43 Completed build in 12m 30s on Fri, 27 Mar, 02:43 PM Test Summary: 9 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1848
-
Benjamin Kott uploaded patch set 11 03/27/20, 14:47
-
TYPO3com voted on patch set 11 V -1 03/27/20, 14:59 Completed build in 11m 49s on Fri, 27 Mar, 02:59 PM Test Summary: 7 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1850
-
TYPO3com commented on patch set 11 03/27/20, 15:06 Completed build in 30m 39s on Fri, 27 Mar, 03:06 PM Test Summary: 7 of 73498 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1850
-
Benjamin Kott uploaded patch set 12 03/27/20, 15:18
-
Benjamin Kott uploaded patch set 13 03/27/20, 15:44
-
TYPO3com voted on patch set 12 V -1 03/27/20, 15:48 Completed build in 23m 31s on Fri, 27 Mar, 03:48 PM Test Summary: 7 of 73501 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1858
-
TYPO3com voted on patch set 13 V -1 03/27/20, 16:25 Completed build in 20m 50s on Fri, 27 Mar, 04:25 PM Test Summary: 71323 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1863
-
TYPO3com voted on patch set 13 V +1 03/27/20, 16:34 Completed build in 51m 09s on Fri, 27 Mar, 04:34 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1863
-
Susi Moog updated the commit message in patch set 14 03/27/20, 16:38
-
Susi Moog commented on patch set 14 03/27/20, 16:39
This change is ready for review. -
Richard Haeser voted on patch set 14 V +1 CR +1 03/27/20, 16:49
-
TYPO3com voted on patch set 14 V +1 03/27/20, 16:54 Completed build in 14m 58s on Fri, 27 Mar, 04:54 PM Test Summary: 73044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1866
-
Riccardo De Contardi commented on patch set 14 V +1 03/27/20, 17:19
I like the new module navigation styling; the dashboard icon should be adjusted (can't have colored background) or even replaced (looks too much like a newspaper folder (?)). I still wonder if it would not be better to replace the initial TYPO3 screen with the dashboard or / and put the icon on the top utility bar for quick access, too -
Benjamin Kott voted on patch set 14 V +1 CR +1 03/27/20, 17:25
-
Anja Leichsenring voted on patch set 14 V +2 CR +2 03/28/20, 07:46
-
Anja Leichsenring merged patch set 15 03/28/20, 07:47
-
Frank Nägler commented on patch set 15 03/28/20, 20:30
post -1: At least in firefox, this patch breaks the backend in multiple cases. login with a closed console (cache enabled): 1) UC set first module in menu => Result: blank page in content frame, menu not work 2) UC set about module => Result: Content frame shows: 404 /typo3/undefined not found Opening the console (cache disabled) solves all problems, but only for this session. After login again with the console closed, the errors happen again. -
Frank Nägler commented on patch set 15 03/28/20, 20:45
sry, I remove my post -1. After restart of FireFox, the issue is gone. Very stupid. -
Riccardo De Contardi commented on patch set 15 03/28/20, 20:53
@Frank Nägler and others it's just a cache problem, I had the same problems with FF and Safari, just clear browser cache -
Claus Due commented on patch set 15 03/30/20, 09:13
Patch has broken the previous behavior of using the first module as starting module when no starting module is defined for the user. -
Benni Mack commented on patch set 15 03/30/20, 19:22
Post -1: Even though the module menu is now easier accessible for mobile & keyboard navigation, the layout with the buttons on top does not align with the module menu items. In addition, the additional spacing/padding now allows to see fewer modules at one glance. -
Benjamin Kott commented on patch set 15 03/30/20, 21:00
> Patch Set 15: > > Post -1: Even though the module menu is now easier accessible for mobile & keyboard navigation, the layout with the buttons on top does not align with the module menu items. In addition, the additional spacing/padding now allows to see fewer modules at one glance. The changes are not only for mobile usage, but for accessibilty in general. It´s currently almost possible to see the active state on bad screens, beamers etc. it´s even getting worse when the module gets collaped. The current size still undercuts the recommended size for touch targets. otherwise we would have to go even bigger. It would be possible to reduce the size by 4 pixels, but this will only help in the non collapsed state, and we would need to increase it again to make the active state more visible. this will result in a jumping of the items on state change that we should avoid. I agree that the topbar needs to be aligned to reflect the latest changes, here. -
Christian Toffolo commented on patch set 15 09/07/20, 08:20
> Patch Set 15: > > > Patch Set 15: > > > > Post -1: Even though the module menu is now easier accessible for mobile & keyboard navigation, the layout with the buttons on top does not align with the module menu items. In addition, the additional spacing/padding now allows to see fewer modules at one glance. > > The changes are not only for mobile usage, but for accessibilty in general. It´s currently almost possible to see the active state on bad screens, beamers etc. it´s even getting worse when the module gets collaped. The current size still undercuts the recommended size for touch targets. otherwise we would have to go even bigger. > > It would be possible to reduce the size by 4 pixels, but this will only help in the non collapsed state, and we would need to increase it again to make the active state more visible. this will result in a jumping of the items on state change that we should avoid. > > I agree that the topbar needs to be aligned to reflect the latest changes, here. Unfortunately I have only now seen this change to the module menu (I have only now started with version 10). IMHO the style of the modules menu in version 10 is a big step back from 9. If I understand correctly, the space between the buttons has been increased for easier touch but the difference is so small that it does not justify the aesthetic deterioration. As for the visibility of the active state, it could also be increased simply by inverting the background (very clear) and text (very dark) in an active item. It would have been better to include such a major change to the module menu in a dedicated patch.
Main.html:5Unresolved