Review main Merged

63724[BUGFIX] Respect sorting when adding main modules

Benni Mack CR +2 V +2 Normal +151 −48 updated 03/19/20, 06:32

Commit message

When adding a new main module, the "position" is now taken into
account, allowing TYPO3 Core also to use the addModule API
everywhere.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1218

  1. Benni Mack uploaded patch set 1 03/14/20, 19:00

  2. TYPO3com voted on patch set 1 V -1 03/14/20, 19:11 Completed build in 11m 07s on Sat, 14 Mar, 07:11 PM Test Summary: 6 of 72685 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1350

  3. Benni Mack uploaded patch set 2 03/16/20, 19:37

  4. Benni Mack uploaded patch set 3 03/16/20, 19:39

  5. Benni Mack updated the commit message in patch set 4 03/16/20, 19:45

  6. TYPO3com voted on patch set 2 V +1 03/16/20, 19:49 Completed build in 11m 22s on Mon, 16 Mar, 07:49 PM Test Summary: 72318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1383

  7. TYPO3com voted on patch set 3 V +1 03/16/20, 19:55 Completed build in 15m 26s on Mon, 16 Mar, 07:55 PM Test Summary: 72318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1384

  8. TYPO3com voted on patch set 4 V +1 03/16/20, 19:59 Completed build in 13m 26s on Mon, 16 Mar, 07:59 PM Test Summary: 72318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1385

  9. Georg Ringer voted on patch set 4 V +1 CR +1 03/17/20, 05:00

  10. Benni Mack commented on patch set 4 CR -1 03/17/20, 07:40

    on it
  11. Benni Mack commented on patch set 4 V -1 03/17/20, 08:57

    ExtensionManagementUtility.php:797 Unresolved

    I do not consider the "_navigationComponents" part yet. which needs to be added.
  12. Benni Mack uploaded patch set 5 03/17/20, 10:17

  13. TYPO3com voted on patch set 5 V -1 03/17/20, 10:31 Completed build in 14m 46s on Tue, 17 Mar, 10:31 AM Test Summary: 48 of 72562 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1391

  14. Benni Mack uploaded patch set 6 03/17/20, 10:39

  15. TYPO3com voted on patch set 6 V +1 03/17/20, 11:00 Completed build in 19m 47s on Tue, 17 Mar, 11:00 AM Test Summary: 72084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1393

  16. Susi Moog voted on patch set 6 V +1 CR +1 03/19/20, 06:22

  17. Georg Ringer voted on patch set 6 V +2 CR +2 03/19/20, 06:32

  18. Georg Ringer merged patch set 7 03/19/20, 06:32