Review main Merged

63727[BUGFIX] Skip invalid type field in LinkAnalyzer

Georg Ringer CR +2 V +2 Easy +3 −1 updated 03/15/20, 07:48

Commit message

Only add the type field to the search fields if it is found in the TCA
columns configuration to avoid failed queries. The table
'sys_file_reference' uses as type 'uid_local:type' which is not a valid
field and would break the query.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Riccardo De Contardi +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 03/14/20, 19:55

  2. Georg Ringer commented on patch set 1 03/14/20, 19:55

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/14/20, 20:07 Completed build in 12m 04s on Sat, 14 Mar, 08:07 PM Test Summary: 61957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1354

  4. Riccardo De Contardi commented on patch set 1 V +1 03/14/20, 21:38

    Before patch: TSConfig `mod.linkvalidator.searchFields.sys_file_reference = link` breaks linkvalidator; After patch: it does not.
  5. Benni Mack voted on patch set 1 V +1 CR +1 03/14/20, 21:47

  6. TYPO3com voted on patch set 1 V +1 03/14/20, 21:51 Completed build in 2h 07m 50s on Sat, 14 Mar, 09:51 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1354

  7. Oli Bartsch voted on patch set 1 CR +1 03/15/20, 00:36

  8. Susi Moog voted on patch set 1 V +2 CR +2 03/15/20, 07:48

  9. Susi Moog merged patch set 2 03/15/20, 07:48