Review main Merged

63728[BUGFIX] Avoid error when using admPanel.hide = 1

Chris Müller CR +2 V +2 Normal +144 −1 updated 03/15/20, 07:30

Commit message

The method StateUtility::isHiddenForUser must return a bool,
but instead the User TSconfig setting admPanel.hide = 1
was returned unchanged as a string. This conflicts with
the defined return type.

Additionally, a check on the backend user is added to
avoid another error when it is null.

Furthermore, missing tests in StateUtility are added.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 610

  1. Chris Müller uploaded patch set 1 03/14/20, 19:56

  2. TYPO3com voted on patch set 1 V +1 03/14/20, 20:13 Completed build in 16m 01s on Sat, 14 Mar, 08:13 PM Test Summary: 72201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1355

  3. Chris Müller uploaded patch set 2 03/14/20, 20:47

  4. TYPO3com voted on patch set 2 V -1 03/14/20, 20:48 Completed build in 44s on Sat, 14 Mar, 08:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1356

  5. TYPO3com commented on patch set 2 03/14/20, 20:54 Completed build in 25s on Sat, 14 Mar, 08:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1357

  6. Chris Müller uploaded patch set 3 03/14/20, 20:56

  7. TYPO3com voted on patch set 3 V +1 03/14/20, 21:14 Completed build in 17m 11s on Sat, 14 Mar, 09:14 PM Test Summary: 72267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1358

  8. Susi Moog voted on patch set 3 V +1 CR +1 03/15/20, 07:26

  9. Georg Ringer voted on patch set 3 V +2 CR +2 03/15/20, 07:30

  10. Georg Ringer merged patch set 4 03/15/20, 07:30