Review main Merged

63730[BUGFIX] Fix some dirty field checks in FormEngine

Christian Eßl CR +2 V +2 Easy +13 −3 updated 03/17/20, 20:09

Commit message

In some cases, the "dirty" field checks were still not working for both
ckeditor and flexform fields. The following changes were made:

- Flexform elements can use dots for html id attributes, which are not
officially supported by the W3C CSS specification. So escape the
corresponding element selectors to work with the validation.
- When maximizing an RTE, ckeditor4 automatically removes all the
classes from the connected html elements (and reapplies them once leaving
the fullscreen mode), so the markFieldAsChanged() validation won't work
here. In this case, apply an event for remembering the changes, once the
user leaves fullscreen again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 69

  1. Christian Eßl uploaded patch set 1 03/15/20, 13:44

  2. Christian Eßl uploaded patch set 2 03/15/20, 13:45

  3. TYPO3com voted on patch set 1 V -1 03/15/20, 13:57 Completed build in 12m 25s on Sun, 15 Mar, 01:57 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1363

  4. TYPO3com voted on patch set 2 V -1 03/15/20, 14:01 Completed build in 14m 37s on Sun, 15 Mar, 02:01 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1364

  5. Christian Eßl rebased onto patch set 3 03/15/20, 18:43

  6. TYPO3com voted on patch set 3 V +1 03/15/20, 18:55 Completed build in 11m 53s on Sun, 15 Mar, 06:55 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1372

  7. Georg Ringer voted on patch set 3 V +1 CR +1 03/17/20, 14:21

  8. Benni Mack voted on patch set 3 V +2 CR +2 03/17/20, 20:09

  9. Benni Mack merged patch set 4 03/17/20, 20:09