Review main Merged

63731[BUGFIX] Fix phpdoc comment reported by phpstan

Christian Eßl CR +2 V +2 Easy +1 −1 updated 03/15/20, 18:23

Commit message

phpstan requires, that a @var PHPDoc comment is immediately followed
by the variable in the next line.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Eßl uploaded patch set 1 03/15/20, 15:31

  2. Oliver Klee voted on patch set 1 CR +1 03/15/20, 15:33

  3. TYPO3com voted on patch set 1 V -1 03/15/20, 15:42 Completed build in 11m 00s on Sun, 15 Mar, 03:42 PM Test Summary: 71973 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1368

  4. TYPO3com voted on patch set 1 V +1 03/15/20, 15:55 Completed build in 11m 06s on Sun, 15 Mar, 03:55 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1369

  5. Georg Ringer voted on patch set 1 V +1 CR +1 03/15/20, 17:48

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 03/15/20, 18:23

  7. Daniel Goerz merged patch set 2 03/15/20, 18:23