Review 9.5 Merged

63734[BUGFIX] Mark field as changed, when changing text in ckeditor source mode

Frank Nägler CR +2 V +2 Easy +9 −0 updated 03/13/20, 20:26

Commit message

Changing content in the 'source' mode textarea of ckeditor does not
automatically trigger a change event for its parent textarea. Because
of that, the field was never marked as "changed" in the FormEngine and
the user would then not receive a warning modal when closing the form
without saving first. This behaviour is now fixed.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Frank Nägler commented on patch set 1 03/13/20, 20:08

    Cherry Picked from branch master.
  2. Frank Nägler voted on patch set 1 V +2 CR +2 03/13/20, 20:20

  3. TYPO3com voted on patch set 1 V +1 03/13/20, 20:24 Completed build in 16m 08s on Fri, 13 Mar, 08:24 PM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-222

  4. Frank Nägler merged patch set 2 03/13/20, 20:26