Review 9.5 Merged

63737[BUGFIX] Make DateViewHelperTests resilient to execution time

Susi Moog CR +2 V +2 Easy +4 −4 updated 03/15/20, 10:29

Commit message

Executing the tests over midnight caused the changed tests to fail
as those where comparing the "current date" from the test subject
with the one gathered within the tests, those not necessarily
are on the same day.

As the DateViewHelper uses the date from the Context we
safely can use the EXEC_TIME of the Core for the expectation.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Susi Moog commented on patch set 1 03/15/20, 08:08

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php
  2. TYPO3com voted on patch set 1 V -1 03/15/20, 08:09 Completed build in 21s on Sun, 15 Mar, 08:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-227

  3. Susi Moog commented on patch set 2 03/15/20, 08:12

    Published edit on patch set 1.
  4. Susi Moog commented on patch set 2 03/15/20, 08:12

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 03/15/20, 08:25 Completed build in 13m 00s on Sun, 15 Mar, 08:25 AM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-228

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/15/20, 09:32

  7. Susi Moog commented on patch set 3 03/15/20, 10:14

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 03/15/20, 10:26 Completed build in 11m 42s on Sun, 15 Mar, 10:26 AM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-229

  9. Susi Moog voted on patch set 3 V +2 CR +2 03/15/20, 10:29

  10. Susi Moog merged patch set 4 03/15/20, 10:29