Review 9.5 Merged

63741[BUGFIX] Respect columnsOverrides in TCA for all field types

Daniel Goerz CR +2 V +2 Normal +73 −7 updated 03/15/20, 11:48

Commit message

These changes in the Datahandler and the FormSlugAjaxController
allow users to override slug fields with columnsOverrides.

Typical usecases for this are custom doktypes which should
have an individual url behaviour defined by their type.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 710

  1. Daniel Goerz commented on patch set 1 03/15/20, 10:36

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php
  2. TYPO3com voted on patch set 1 V -1 03/15/20, 10:38 Completed build in 55s on Sun, 15 Mar, 10:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-236

  3. Daniel Goerz commented on patch set 2 03/15/20, 10:41

    Published edit on patch set 1.
  4. Daniel Goerz commented on patch set 3 03/15/20, 10:42

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 03/15/20, 11:14 Completed build in 18m 43s on Sun, 15 Mar, 11:14 AM Test Summary: 74547 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-238

  6. TYPO3com voted on patch set 3 V +1 03/15/20, 11:20 Completed build in 23m 49s on Sun, 15 Mar, 11:20 AM Test Summary: 74547 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-239

  7. Daniel Goerz commented on patch set 3 03/15/20, 11:32

    This change is ready for review.
  8. Susi Moog voted on patch set 3 V +1 CR +1 03/15/20, 11:40

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 03/15/20, 11:48

  10. Daniel Goerz merged patch set 4 03/15/20, 11:48