Review 9.5 Merged

63745[BUGFIX] Make SQL schema migrations working on SQLite

Benni Mack CR +2 V +2 Hard +48 −878 updated 03/17/20, 08:14

Commit message

This patch fixes three things:

1) SQLite can handle a primary key, the special handling
   can be removed. The field names must be quoted though.
   A lot of duplicate tests can be removed here.

2) The handcrafted arrays passed on to the TableDiff class
   need to be indexed by the column or index name, otherwise
   the SQLite driver fails to identify them correctly.

3) Allow only one column operation per table.
   Having multiple column adjustments (rename, removal)
   within one run generates wrong migration SQL.
   This is due to the possibility of the Install Tool
   to be able to select on a "per column" level.
   (Keep in mind that in SQLite one operation needs at
   least 5 SQL statements, contrary to other DMBS)

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 4

Review log 46

  1. Benni Mack commented on patch set 1 03/16/20, 20:06

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaSqliteTest.php
  2. TYPO3com voted on patch set 1 V -1 03/16/20, 20:06 Completed build in 22s on Mon, 16 Mar, 08:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-246

  3. Benni Mack commented on patch set 2 03/16/20, 20:06

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 03/16/20, 20:22 Completed build in 15m 21s on Mon, 16 Mar, 08:22 PM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-247

  5. Benni Mack commented on patch set 2 V +2 CR +2 03/17/20, 08:14

    This change is ready for review.
  6. Benni Mack merged patch set 3 03/17/20, 08:14