Review 9.5 Merged

63746[TASK] Use no-cookie setting for vimeo by default

Benni Mack CR +2 V +2 Easy +17 −0 updated 03/17/20, 20:38

Commit message

Improve the privacy of users by using the no-cookie setting
by default and set the do not track parameter to 1.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 610

  1. Benni Mack commented on patch set 1 03/17/20, 10:24

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php * typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php
  2. TYPO3com voted on patch set 1 V -1 03/17/20, 10:25 Completed build in 20s on Tue, 17 Mar, 10:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-248

  3. Benni Mack commented on patch set 2 03/17/20, 10:25

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 03/17/20, 10:25 Completed build in 21s on Tue, 17 Mar, 10:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-249

  5. Benni Mack commented on patch set 3 03/17/20, 19:57

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V -1 03/17/20, 20:09 Completed build in 11m 09s on Tue, 17 Mar, 08:09 PM Test Summary: 12 of 74913 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-250

  7. Benni Mack commented on patch set 4 03/17/20, 20:12

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V +1 03/17/20, 20:37 Completed build in 13m 39s on Tue, 17 Mar, 08:37 PM Test Summary: 74307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-252

  9. Benni Mack commented on patch set 4 V +2 CR +2 03/17/20, 20:38

    This change is ready for review.
  10. Benni Mack merged patch set 5 03/17/20, 20:38