Review 9.5 Merged

63749[TASK] Allow editing of crdate in sys_news

Georg Ringer CR +2 V +2 Easy +11 −2 updated 03/18/20, 07:54

Commit message

As system news are sorted by crdate, the user had no way to influence
the order in which news appeared. While it makes sense to sort by
creation, users should have an option to influence that.

Changing to tstamp would not be a solution, as tstamp changes on every
edit (for example correcting a spelling mistake should not change the
order). Adding an explicit sorting field seems like overkill (and would
need upgrade wizards and DB changes). Therefor TCA has been changed to
allow editing of the creation date for these kinds of records.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 03/18/20, 07:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/18/20, 07:38 Completed build in 12m 30s on Wed, 18 Mar, 07:38 AM Test Summary: 74307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-256

  3. Georg Ringer voted on patch set 1 V +2 CR +2 03/18/20, 07:54

  4. Georg Ringer merged patch set 2 03/18/20, 07:54