63751[BUGFIX] Ensure cache tags are available on cached pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- anonymized-52878 +1
-
Verified V +2 Done
- Benni Mack +2
- anonymized-52878 +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1014
-
Susi Moog commented on patch set 1 03/19/20, 09:17
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php -
Susi Moog uploaded patch set 2 03/19/20, 09:18
-
Susi Moog commented on patch set 2 03/19/20, 09:19
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/19/20, 09:29 Completed build in 11m 53s on Thu, 19 Mar, 09:29 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-260
-
TYPO3com voted on patch set 2 V +1 03/19/20, 09:33 Completed build in 13m 18s on Thu, 19 Mar, 09:33 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-261
-
Benni Mack commented on patch set 2 CR -1 03/19/20, 11:07
This is not correct. -
Benni Mack commented on patch set 3 03/19/20, 11:09
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 03/19/20, 11:21 Completed build in 12m 25s on Thu, 19 Mar, 11:21 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-264
-
anonymized-52878 commented on patch set 3 V -1 CR -1 03/19/20, 11:27
This patch is wrong. Line 2458 needs to be changed to: $this->pageCacheTags = $row['cacheTags'] ?? []; -
Benni Mack commented on patch set 4 03/19/20, 11:29
Published edit on patch set 3. -
anonymized-52878 voted on patch set 4 V +1 CR +1 03/19/20, 11:35
-
TYPO3com voted on patch set 4 V +1 03/19/20, 11:47 Completed build in 17m 14s on Thu, 19 Mar, 11:47 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-270
-
Benni Mack commented on patch set 4 V +2 CR +2 03/19/20, 11:55
Thanks! -
Benni Mack merged patch set 5 03/19/20, 11:55