Review 9.5 Merged

63751[BUGFIX] Ensure cache tags are available on cached pages

Susi Moog CR +2 V +2 Easy +4 −0 updated 03/19/20, 11:55

Commit message

When fetching a page from cache, the information which cache
tags were used are not available anymore for any hooks in extensions
(e.g. static_filecache).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • anonymized-52878 +1
  • Verified V +2 Done
    • Benni Mack +2
    • anonymized-52878 +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Susi Moog commented on patch set 1 03/19/20, 09:17

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
  2. Susi Moog uploaded patch set 2 03/19/20, 09:18

  3. Susi Moog commented on patch set 2 03/19/20, 09:19

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V +1 03/19/20, 09:29 Completed build in 11m 53s on Thu, 19 Mar, 09:29 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-260

  5. TYPO3com voted on patch set 2 V +1 03/19/20, 09:33 Completed build in 13m 18s on Thu, 19 Mar, 09:33 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-261

  6. Benni Mack commented on patch set 2 CR -1 03/19/20, 11:07

    This is not correct.
  7. Benni Mack commented on patch set 3 03/19/20, 11:09

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 03/19/20, 11:21 Completed build in 12m 25s on Thu, 19 Mar, 11:21 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-264

  9. anonymized-52878 commented on patch set 3 V -1 CR -1 03/19/20, 11:27

    This patch is wrong. Line 2458 needs to be changed to: $this->pageCacheTags = $row['cacheTags'] ?? [];
  10. Benni Mack commented on patch set 4 03/19/20, 11:29

    Published edit on patch set 3.
  11. anonymized-52878 voted on patch set 4 V +1 CR +1 03/19/20, 11:35

  12. TYPO3com voted on patch set 4 V +1 03/19/20, 11:47 Completed build in 17m 14s on Thu, 19 Mar, 11:47 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-270

  13. Benni Mack commented on patch set 4 V +2 CR +2 03/19/20, 11:55

    Thanks!
  14. Benni Mack merged patch set 5 03/19/20, 11:55