Review main Merged

63752[BUGFIX] Make backend.user conditions in FE work

Benni Mack CR +2 V +2 Easy +11 −2 updated 04/30/20, 14:26

Commit message

The TypoScript conditions "[backend.user.*]" are documented,
but were never implemented.

https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Conditions/Index.html#backend-user

This patch is now introducing the missing conditions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Julian Mair +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1725

  1. Benni Mack uploaded patch set 1 03/16/20, 15:22

  2. Georg Ringer voted on patch set 1 V +1 CR +1 03/16/20, 15:26

  3. Susi Moog voted on patch set 1 V +1 CR +1 03/16/20, 15:28

  4. TYPO3com voted on patch set 1 V -1 03/16/20, 15:33 Completed build in 11m 23s on Mon, 16 Mar, 03:33 PM Test Summary: 15 of 72754 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1379

  5. Susi Moog uploaded patch set 2 03/20/20, 06:47

  6. TYPO3com voted on patch set 2 V -1 03/20/20, 07:02 Completed build in 07m 12s on Fri, 20 Mar, 07:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1480

  7. Susi Moog commented on patch set 3 03/20/20, 07:40

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V -1 03/20/20, 08:04 Completed build in 19m 29s on Fri, 20 Mar, 08:04 AM Test Summary: 15 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1482

  9. TYPO3com commented on patch set 3 04/24/20, 14:45 Completed build in 11m 16s on Fri, 24 Apr, 02:45 PM Test Summary: 15 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3020

  10. Susi Moog uploaded patch set 4 04/26/20, 06:50

  11. TYPO3com voted on patch set 4 V -1 04/26/20, 07:02 Completed build in 11m 52s on Sun, 26 Apr, 07:02 AM Test Summary: 15 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3027

  12. Susi Moog uploaded patch set 5 04/26/20, 11:41

  13. TYPO3com voted on patch set 5 V -1 04/26/20, 11:53 Completed build in 11m 42s on Sun, 26 Apr, 11:53 AM Test Summary: 15 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3032

  14. Susi Moog uploaded patch set 6 04/26/20, 12:50

  15. TYPO3com voted on patch set 6 V -1 04/26/20, 12:51 Completed build in 23s on Sun, 26 Apr, 12:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3033

  16. Susi Moog uploaded patch set 7 04/26/20, 12:59

  17. TYPO3com voted on patch set 7 V +1 04/26/20, 13:10 Completed build in 11m 34s on Sun, 26 Apr, 01:10 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3034

  18. Benni Mack commented on patch set 7 04/27/20, 18:49

    Please vote/review/test if you want to have this in for tomorrow's release.
  19. Andreas Kienast voted on patch set 7 CR +1 04/27/20, 18:50

  20. Julian Mair voted on patch set 7 CR +1 04/27/20, 20:34

  21. Susi Moog voted on patch set 7 V +1 CR +1 04/28/20, 07:36

  22. Benni Mack voted on patch set 7 V +2 CR +2 04/28/20, 07:37

  23. Benni Mack merged patch set 8 04/28/20, 07:37

  24. Josef Glatz commented on patch set 8 04/30/20, 13:18

    There was already a working condition: > [getTSFE().isBackendUserLoggedIn()] is it really necessary to have two of them to maintain?
  25. Josef Glatz commented on patch set 8 04/30/20, 14:26

    > Patch Set 8: > > There was already a working condition: > > > [getTSFE().isBackendUserLoggedIn()] > > is it really necessary to have two of them to maintain? beside that: we have to adopt the condition docs for typoscript, tsconfig and condition ref (according to susi)