Review main Merged

63755[BUGFIX] Allow functions in foreign_table_where clause

Susi Moog CR +2 V +2 Easy +2 −2 updated 03/23/20, 11:08

Commit message

The parser for foreign_table_where consists of
a basic regex that did not allow the use of field
functions due to its character restrictions.

The character match group has been adjusted to allow
the following chars additionally: ")(

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1113

  1. Susi Moog uploaded patch set 1 03/17/20, 08:10

  2. TYPO3com voted on patch set 1 V +1 03/17/20, 08:23 Completed build in 12m 41s on Tue, 17 Mar, 08:23 AM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1388

  3. Susi Moog updated the commit message in patch set 2 03/17/20, 09:20

  4. TYPO3com voted on patch set 2 V +1 03/17/20, 09:33 Completed build in 12m 29s on Tue, 17 Mar, 09:33 AM Test Summary: 72030 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1390

  5. Oli Bartsch commented on patch set 2 03/17/20, 12:48

    Using the example from #88166 `ORDER BY LOWER(tx_my_table.name) ASC` I still get the error.
  6. Oliver Klee commented on patch set 2 03/17/20, 15:46

    Can we cover this with tests?
  7. Susi Moog commented on patch set 2 03/19/20, 09:30

    > Patch Set 2: > > Using the example from #88166 `ORDER BY LOWER(tx_my_table.name) ASC` I still get the error. can you debug what parts are splitted?
  8. Susi Moog commented on patch set 2 03/19/20, 09:31

    > Patch Set 2: > > Can we cover this with tests? thought about that, too - however, not as easy as I wanted it to be - ideally, we'd refactor the whole thing, at the moment we'd rather mock a lot of things and don't get a good result as there is "more magic" in the next steps that only together make a unit out of it.
  9. Oli Bartsch voted on patch set 2 V +1 CR +1 03/23/20, 08:30

  10. Guido Schmechel voted on patch set 2 CR +1 03/23/20, 09:18

  11. Georg Ringer voted on patch set 2 CR +1 03/23/20, 09:55

  12. Benni Mack voted on patch set 2 V +2 CR +2 03/23/20, 11:08

  13. Benni Mack merged patch set 3 03/23/20, 11:08