Review main Abandoned

63759[BUGFIX] Add debug value to SelectCheckBoxElement

Georg Ringer CR 0 V 0 Easy +5 −1 updated 10/08/21, 08:09

Commit message

The rendering of fields is improved for admin users if [BE][debug] is
enabled as it shows the value of the field next to the label.

Render the value also for fields using the SelectCheckBoxElement. One
example usage is the field `non_exclude_fields` in the table
`be_groups`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1927

Show 12 earlier messages
  1. Georg Ringer uploaded patch set 1 03/17/20, 13:54

  2. TYPO3com voted on patch set 1 V -1 03/17/20, 13:56 Completed build in 26s on Tue, 17 Mar, 01:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1402

  1. Georg Ringer commented on patch set 2 03/17/20, 21:34

    Published edit on patch set 1.
  2. TYPO3com voted on patch set 2 V +1 03/17/20, 21:47 Completed build in 12m 03s on Tue, 17 Mar, 09:46 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1406

  3. Georg Ringer uploaded patch set 3 03/30/20, 18:25

  4. Georg Ringer commented on patch set 3 03/30/20, 18:26

    This change is ready for review.
  5. Georg Ringer updated the commit message in patch set 4 03/30/20, 18:26

  6. Christian Eßl commented on patch set 4 03/30/20, 18:35

    Lol, wasthinking about the same improvement just yesterday. ;) But if you go to the "Mounts & Workspaces" tab of a be_user or be_group, you now get nonsensical debug value for file_permissions. (Key value of the first item)
  7. TYPO3com voted on patch set 3 V +1 03/30/20, 18:36 Completed build in 10m 56s on Mon, 30 Mar, 06:36 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1983

  8. TYPO3com voted on patch set 4 V +1 03/30/20, 18:42 Completed build in 15m 03s on Mon, 30 Mar, 06:42 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1984

  9. Benni Mack commented on patch set 4 03/30/20, 19:01

    SelectCheckBoxElement.php:180 Unresolved

    you know, you could do: [$tableName] = explode(':', $group['items'][0]['value']);
  10. Benni Mack commented on patch set 5 03/30/20, 19:34

    Published edit on patch set 4.
  11. TYPO3com voted on patch set 5 V +1 03/30/20, 19:49 Completed build in 14m 38s on Mon, 30 Mar, 07:49 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1986

  12. Benni Mack voted on patch set 5 V +1 CR +1 03/30/20, 20:42

  13. Markus Klein commented on patch set 5 03/31/20, 11:54

    SelectCheckBoxElement.php:179 Unresolved

    I would check $group['items'][0]['value'] here just to be sure that 'value' is really there
  14. Markus Klein commented on patch set 6 03/31/20, 11:55

    Published edit on patch set 5.
  15. TYPO3com voted on patch set 6 V -1 03/31/20, 12:17 Completed build in 19m 28s on Tue, 31 Mar, 12:17 PM Test Summary: 38 of 73537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2024

  16. TYPO3com voted on patch set 6 V +1 03/31/20, 17:11 Completed build in 5h 33m 52s on Tue, 31 Mar, 05:11 PM Test Summary: 73050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2024

  17. Markus Klein voted on patch set 6 V +1 CR +1 03/31/20, 20:18

  18. Christian Eßl commented on patch set 6 V -1 04/01/20, 06:30

    This solution still returns wrong/nonsensical debug information for the "file_permissions" field (and possibly others as well). See screenshot in forge.
  19. Anja Leichsenring wrote 04/13/20, 08:25

    Removed reviewer Anja Leichsenring.
  20. Benni Mack updated the commit message in patch set 7 05/25/20, 18:47

  21. Benni Mack rebased onto patch set 8 09/10/20, 19:55

  22. TYPO3com voted on patch set 8 V +1 09/10/20, 20:14 Completed build in 14m 29s on Thu, 10 Sep, 08:14 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5521

  23. Guido Schmechel commented on patch set 8 V -1 09/26/20, 10:13

    see comment from Christian
  24. Benni Mack commented on patch set 8 10/08/21, 08:08

    ping. If there is no progress, I will abandon this change for the time being.
  25. Georg Ringer abandoned the change 10/08/21, 08:09