63761[BUGFIX] Hide fields for backend users / groups if not enabled
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Hooks/TcaDisplayConditions.phpnew+60 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −0
- typo3/sysext/core/Configuration/TCA/be_users.php+2 −0
- typo3/sysext/core/Tests/Functional/Tca/BackendGroupsVisibleFieldsTest.php+0 −1
- typo3/sysext/core/Tests/Functional/Tca/BackendUsersVisibleFieldsTest.php+0 −2
Review log 68
-
Benni Mack uploaded patch set 1 03/17/20, 20:26
-
TYPO3com voted on patch set 1 V -1 03/17/20, 20:52 Completed build in 14m 25s on Tue, 17 Mar, 08:52 PM Test Summary: 9 of 72520 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1405
-
Stefan Neufeind commented on patch set 1 V -1 CR +1 03/17/20, 23:27
Code looks good. Functional tests fail because the display-conditions kick in and the fields are now hidden (as expected). So some mocking for the functionals is needed. -
Benni Mack uploaded patch set 2 03/19/20, 19:46
-
TYPO3com voted on patch set 2 V +1 03/19/20, 19:58 Completed build in 11m 35s on Thu, 19 Mar, 07:58 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1471
-
Georg Ringer voted on patch set 2 V +1 CR +1 03/19/20, 20:37
-
Susi Moog voted on patch set 2 V +2 CR +2 03/20/20, 06:29
-
Susi Moog merged patch set 3 03/20/20, 06:29