Review main Merged

63761[BUGFIX] Hide fields for backend users / groups if not enabled

Benni Mack CR +2 V +2 Normal +63 −3 updated 03/20/20, 06:29

Commit message

The fields
* be_groups.workspace_perms
* be_users.workspace_perms
* be_users.disableIPlock

Are now only shown if the requirements are met (e.g. EXT:workspaces
is installed, or the IPlock options are enabled

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 68

  1. Benni Mack uploaded patch set 1 03/17/20, 20:26

  2. TYPO3com voted on patch set 1 V -1 03/17/20, 20:52 Completed build in 14m 25s on Tue, 17 Mar, 08:52 PM Test Summary: 9 of 72520 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1405

  3. Stefan Neufeind commented on patch set 1 V -1 CR +1 03/17/20, 23:27

    Code looks good. Functional tests fail because the display-conditions kick in and the fields are now hidden (as expected). So some mocking for the functionals is needed.
  4. Benni Mack uploaded patch set 2 03/19/20, 19:46

  5. TYPO3com voted on patch set 2 V +1 03/19/20, 19:58 Completed build in 11m 35s on Thu, 19 Mar, 07:58 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1471

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/19/20, 20:37

  7. Susi Moog voted on patch set 2 V +2 CR +2 03/20/20, 06:29

  8. Susi Moog merged patch set 3 03/20/20, 06:29