Review main Merged

63762[TASK] Allow editing of crdate in sys_news

Susi Moog CR +2 V +2 Easy +11 −2 updated 03/18/20, 07:35

Commit message

As system news are sorted by crdate, the user had no way to influence
the order in which news appeared. While it makes sense to sort by
creation, users should have an option to influence that.

Changing to tstamp would not be a solution, as tstamp changes on every
edit (for example correcting a spelling mistake should not change the
order). Adding an explicit sorting field seems like overkill (and would
need upgrade wizards and DB changes). Therefor TCA has been changed to
allow editing of the creation date for these kinds of records.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan P +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan P +1

Issues 1

Files 1

Review log 710

  1. Susi Moog uploaded patch set 1 03/18/20, 06:33

  2. TYPO3com voted on patch set 1 V +1 03/18/20, 07:02 Completed build in 21m 20s on Wed, 18 Mar, 07:02 AM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1407

  3. Oli Bartsch rebased onto patch set 2 03/18/20, 07:05

  4. Oli Bartsch uploaded patch set 3 03/18/20, 07:05

  5. Oli Bartsch voted on patch set 3 V +1 CR +1 03/18/20, 07:07

  6. Stefan P commented on patch set 3 V +1 CR +1 03/18/20, 07:15

    Works.
  7. TYPO3com voted on patch set 2 V +1 03/18/20, 07:22 Completed build in 14m 50s on Wed, 18 Mar, 07:22 AM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1409

  8. Georg Ringer voted on patch set 3 V +2 CR +2 03/18/20, 07:25

  9. Georg Ringer merged patch set 4 03/18/20, 07:25

  10. TYPO3com voted on patch set 3 V +1 03/18/20, 07:35 Completed build in 18m 00s on Wed, 18 Mar, 07:35 AM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1410