Review main Merged

63764[BUGFIX] Allow setting categories containing spaces

Georg Ringer CR +2 V +2 Normal +56 −2 updated 03/20/20, 06:35

Commit message

Partly revert #89956 to reallow category titles in extension settings
which contain a space.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Georg Ringer uploaded patch set 1 03/18/20, 12:53

  2. Georg Ringer commented on patch set 1 03/18/20, 12:53

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/18/20, 13:04 Completed build in 11m 24s on Wed, 18 Mar, 01:04 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1415

  4. Oli Bartsch commented on patch set 1 03/18/20, 21:19

    NoSpaceViewHelper.php:51 Unresolved

    Let’s use `preg_replace('/\s+/', '', $arguments['value']);` to really catch all possible white spaces.
  5. Andreas Kienast uploaded patch set 2 03/19/20, 17:24

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 03/19/20, 17:25

  7. TYPO3com voted on patch set 2 V -1 03/19/20, 17:36 Completed build in 11m 29s on Thu, 19 Mar, 05:36 PM Test Summary: 71706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1465

  8. Oli Bartsch voted on patch set 2 CR +1 03/19/20, 17:45

  9. TYPO3com voted on patch set 2 V +1 03/19/20, 17:52 Completed build in 39m 18s on Thu, 19 Mar, 05:52 PM Test Summary: 72113 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1465

  10. Susi Moog voted on patch set 2 V +2 CR +2 03/20/20, 06:35

  11. Susi Moog merged patch set 3 03/20/20, 06:35