Review main Merged

63770[BUGFIX] Check for a maximum lifetime of 1h for workspace swap locking

Benni Mack CR +2 V +2 Easy +9 −4 updated 03/19/20, 12:12

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 611

  1. Benni Mack uploaded patch set 1 03/18/20, 21:59

  2. TYPO3com voted on patch set 1 V +1 03/18/20, 22:11 Completed build in 11m 54s on Wed, 18 Mar, 10:11 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1422

  3. Andreas Kienast commented on patch set 1 03/19/20, 06:04

    DataHandlerHook.php:622 Unresolved

    Shouldn't this be "?:" instead? IIRC file_get_contents() doesn't return null.
  4. Benni Mack commented on patch set 2 03/19/20, 09:27

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V -1 03/19/20, 09:44 Completed build in 12m 32s on Thu, 19 Mar, 09:44 AM Test Summary: 61833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1435

  6. TYPO3com commented on patch set 2 03/19/20, 11:12 Completed build in 1h 52m 51s on Thu, 19 Mar, 11:12 AM Test Summary: 61833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1435

  7. TYPO3com commented on patch set 2 03/19/20, 11:33 Completed build in 3h 54m 30s on Thu, 19 Mar, 11:33 AM Test Summary: 61833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1435

  8. Benni Mack uploaded patch set 3 03/19/20, 11:38

  9. TYPO3com voted on patch set 3 V +1 03/19/20, 11:55 Completed build in 17m 15s on Thu, 19 Mar, 11:55 AM Test Summary: 72108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1442

  10. Benni Mack voted on patch set 3 V +2 CR +2 03/19/20, 12:12

  11. Benni Mack merged patch set 4 03/19/20, 12:12