Review main Merged

63771[TASK] Optimize wording for reset backend password functionality

Michael Schams CR +2 V +2 Normal +36 −39 updated 03/25/20, 07:25

Commit message

This change updates the email texts and subject lines for HTML and plain
text mails, as well as some labels in the backend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1519

  1. Michael Schams uploaded patch set 1 03/19/20, 07:27

  2. Michael Schams commented on patch set 1 03/19/20, 07:30

    Still work in progress.
  3. TYPO3com voted on patch set 1 V +1 03/19/20, 07:38 Completed build in 10m 55s on Thu, 19 Mar, 07:38 AM Test Summary: 72084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1427

  4. Georg Ringer commented on patch set 1 03/19/20, 08:39

    ResetRequested.html:6

    shouldn't be "" fine?

    ResetRequested.html:15 Unresolved

    should we move that to a partial?
  5. Oliver Klee commented on patch set 1 03/19/20, 11:03

    AmbiguousResetRequested.txt:6

    Please let's generally add a "Please" at the start of this sentence (in all changed files).

    ResetRequested.html:6 Reply Unresolved

    No, double quotes in HTML need to be encoded.
  6. Benni Mack commented on patch set 1 03/19/20, 11:20

    Great work, thank you. Could we also move them into XLF files directly?
  7. Michael Schams commented on patch set 1 03/19/20, 11:22

    > Patch Set 1: > > (2 comments)

    AmbiguousResetRequested.txt:6 Reply

    This would result in: "Please ask your administrator..." and further down: "[...], please let your administrator know." Doesn't sound good to me to be honest.
  8. Oliver Klee commented on patch set 1 03/19/20, 11:24

    AmbiguousResetRequested.txt:6 Reply Unresolved

    Hi Michael, does the "please" not sound good to know, or is it placement of the "please" at the beginning of the sentence?
  9. Michael Schams uploaded patch set 2 03/20/20, 06:16

  10. TYPO3com voted on patch set 2 V +1 03/20/20, 06:37 Completed build in 20m 21s on Fri, 20 Mar, 06:37 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1476

  11. Michael Schams uploaded patch set 3 03/20/20, 06:39

  12. Michael Schams updated the commit message in patch set 4 03/20/20, 06:40

  13. TYPO3com voted on patch set 3 V -1 03/20/20, 07:12 Completed build in 32m 36s on Fri, 20 Mar, 07:12 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1478

  14. TYPO3com voted on patch set 4 V +1 03/20/20, 07:18 Completed build in 22m 36s on Fri, 20 Mar, 07:18 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1479

  15. Michael Schams commented on patch set 4 03/24/20, 21:24

    Thanks for the follow-up, Georg. The updates are complete from my perspective. Please review and verify.
  16. Georg Ringer voted on patch set 4 V +1 CR +1 03/24/20, 21:36

  17. Benni Mack commented on patch set 4 03/24/20, 21:59

    Still my question remains? Do we want to move this to localized (XLF) content?
  18. Benni Mack commented on patch set 4 V +2 CR +2 03/25/20, 07:25

    Let's save the XLF extraction for another change to keep the intent of the changes separate! Thanks a lot!
  19. Benni Mack merged patch set 5 03/25/20, 07:25