63771[TASK] Optimize wording for reset backend password functionality
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Resources/Private/Language/locallang_reset_password.xlf+6 −6
- typo3/sysext/backend/Resources/Private/Partials/Email/PasswordReset/ClosingParagraph.htmlnew+6 −0
- typo3/sysext/backend/Resources/Private/Partials/Email/PasswordReset/ClosingParagraph.txtnew+2 −0
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/AmbiguousResetRequested.html+6 −8
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/AmbiguousResetRequested.txt3+4 −8
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/ResetRequested.html3+8 −8
- typo3/sysext/backend/Resources/Private/Templates/Email/PasswordReset/ResetRequested.txt+3 −8
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+1 −1
Review log 1519
-
Michael Schams uploaded patch set 1 03/19/20, 07:27
-
Michael Schams commented on patch set 1 03/19/20, 07:30
Still work in progress. -
TYPO3com voted on patch set 1 V +1 03/19/20, 07:38 Completed build in 10m 55s on Thu, 19 Mar, 07:38 AM Test Summary: 72084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1427
-
Georg Ringer commented on patch set 1 03/19/20, 08:39
ResetRequested.html:6shouldn't be "" fine?ResetRequested.html:15Unresolvedshould we move that to a partial? -
Oliver Klee commented on patch set 1 03/19/20, 11:03
AmbiguousResetRequested.txt:6Please let's generally add a "Please" at the start of this sentence (in all changed files).ResetRequested.html:6Reply UnresolvedNo, double quotes in HTML need to be encoded. -
Benni Mack commented on patch set 1 03/19/20, 11:20
Great work, thank you. Could we also move them into XLF files directly? -
Michael Schams commented on patch set 1 03/19/20, 11:22
> Patch Set 1: > > (2 comments)AmbiguousResetRequested.txt:6ReplyThis would result in: "Please ask your administrator..." and further down: "[...], please let your administrator know." Doesn't sound good to me to be honest. -
Oliver Klee commented on patch set 1 03/19/20, 11:24
AmbiguousResetRequested.txt:6Reply UnresolvedHi Michael, does the "please" not sound good to know, or is it placement of the "please" at the beginning of the sentence? -
Michael Schams uploaded patch set 2 03/20/20, 06:16
-
TYPO3com voted on patch set 2 V +1 03/20/20, 06:37 Completed build in 20m 21s on Fri, 20 Mar, 06:37 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1476
-
Michael Schams uploaded patch set 3 03/20/20, 06:39
-
Michael Schams updated the commit message in patch set 4 03/20/20, 06:40
-
TYPO3com voted on patch set 3 V -1 03/20/20, 07:12 Completed build in 32m 36s on Fri, 20 Mar, 07:12 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1478
-
TYPO3com voted on patch set 4 V +1 03/20/20, 07:18 Completed build in 22m 36s on Fri, 20 Mar, 07:18 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1479
-
Michael Schams commented on patch set 4 03/24/20, 21:24
Thanks for the follow-up, Georg. The updates are complete from my perspective. Please review and verify. -
Georg Ringer voted on patch set 4 V +1 CR +1 03/24/20, 21:36
-
Benni Mack commented on patch set 4 03/24/20, 21:59
Still my question remains? Do we want to move this to localized (XLF) content? -
Benni Mack commented on patch set 4 V +2 CR +2 03/25/20, 07:25
Let's save the XLF extraction for another change to keep the intent of the changes separate! Thanks a lot! -
Benni Mack merged patch set 5 03/25/20, 07:25