Review 9.5 Merged

63772[TASK] Remove superfluous UriBuilder references

Susi Moog CR +2 V +2 Normal +26 −26 updated 03/19/20, 12:34

Commit message

Avoid calling GeneralUtility::makeInstance() in UriBuilder
multiple time, but add class member instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Susi Moog commented on patch set 1 03/19/20, 09:23

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/EditDocumentController.php * typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php
  2. TYPO3com voted on patch set 1 V -1 03/19/20, 09:25 Completed build in 33s on Thu, 19 Mar, 09:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-262

  3. Susi Moog uploaded patch set 2 03/19/20, 09:28

  4. Susi Moog commented on patch set 2 03/19/20, 09:28

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 03/19/20, 09:53 Completed build in 21m 10s on Thu, 19 Mar, 09:53 AM Test Summary: 74301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-263

  6. Benni Mack voted on patch set 2 V +2 CR +2 03/19/20, 12:34

  7. Benni Mack merged patch set 3 03/19/20, 12:34