Review 9.5 Merged

63774[TASK] Make tests PHPUnit v9 compatible

Benni Mack CR +2 V +2 Easy +18 −6 updated 03/19/20, 15:21

Commit message

This change modifies "->expectExceptionMessageRegExp" which is
not available anymore in PHPunit v9.

In addition, expectException(Warning::class) is deprecated in PHPUnit v9,
which is modified as well, to make Core a small step towards PHPUnit v10 compat.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 03/19/20, 15:00

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php * typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
  2. TYPO3com voted on patch set 1 V -1 03/19/20, 15:00 Completed build in 22s on Thu, 19 Mar, 03:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-273

  3. Benni Mack uploaded patch set 2 03/19/20, 15:03

  4. TYPO3com voted on patch set 2 V +1 03/19/20, 15:15 Completed build in 11m 53s on Thu, 19 Mar, 03:15 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-274

  5. Benni Mack commented on patch set 2 V +2 CR +2 03/19/20, 15:21

    This change is ready for review.
  6. Benni Mack merged patch set 3 03/19/20, 15:21