Review 9.5 Merged

63776[BUGFIX] Cast string to float in NumberViewHelper

Benni Mack CR +2 V +2 Easy +17 −1 updated 03/19/20, 19:33

Commit message

While number_format does an internal cast to float, it does not cast
things like empty strings to 0 - instead a PHP warning is emitted.

To catch that edge case, we are now casting to float before calling
number_format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack commented on patch set 1 03/19/20, 16:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/19/20, 16:43 Completed build in 13m 30s on Thu, 19 Mar, 04:43 PM Test Summary: 74331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-276

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/19/20, 18:12

  4. Oliver Klee voted on patch set 1 CR +1 03/19/20, 18:32

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/19/20, 19:33

  6. Benni Mack merged patch set 2 03/19/20, 19:33