Review TYPO3_4-6 Merged

6378[BUGFIX] Multiple values not displayed for simple items lists

Francois Suter CR +2 V +2 Easy +37 −2 updated 06/03/13, 20:49

Commit message

t3lib_BEfunc::getProcessedValue() is used throughout the Core to
transform values stored as indices into human-readable values.

However for select-type fields based on a list of items
(and not a foreign table) where multiple selections are possible,
t3lib_BEfunc::getProcessedValue() fails to display anything.
This is due to t3lib_BEfunc::getLabelFromItemlist(),
being unable to handle several values.

This patch introduces a new method to avoid breaking compatibility.

Review

  • Code review CR +2
    • Francois Suter +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2
    • Francois Suter +2
    • Markus Klein +1

Issues 1

Files 1

Review log 11

  1. Francois Suter uploaded patch set 2 12/16/11, 13:11

  2. Francois Suter commented on patch set 2 12/16/11, 13:11

    New patch takes into account the whitespace/tab changes from merged version for TYPO3 4.5.
  3. Michael Stucki commented on patch set 3 12/16/11, 13:11

    Looks good to me, but someone else must approve Code review is fine but I haven't tested it yet.
  4. Markus Klein uploaded patch set 3 12/16/11, 13:11

  5. Markus Klein commented on patch set 4 12/16/11, 13:11

    Looks good to me, but someone else must approve
  6. Markus Klein voted on patch set 4 V 0 12/16/11, 13:11

  7. Oliver Hader uploaded patch set 4 12/16/11, 13:11

  8. Oliver Hader commented on patch set 4 12/16/11, 13:11

    Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-6 - Please consider updating your reviews V:0, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Michael Stucki <michael.stucki@typo3.org>
  9. Xavier Perseguers commented on patch set 2 12/16/11, 13:11

    I fixed the commit message (typo in title) in master. Please do it here as well once master is merged
  10. Francois Suter commented on patch set 4 V 0 12/16/11, 13:11

    by team member; Looks good to me, approved
  11. Francois Suter merged patch set 4 12/16/11, 13:11