Review main Merged

6379[BUGFIX] Multiple values not displayed for simple items lists

Francois Suter CR +2 V +2 Easy +37 −2 updated 06/03/13, 20:49

Commit message

t3lib_BEfunc::getProcessedValue() is used throughout the Core to
transform values stored as indices into human-readable values.

However for select-type fields based on a list of items
(and not a foreign table) where multiple selections are possible,
t3lib_BEfunc::getProcessedValue() fails to display anything.
This is due to t3lib_BEfunc::getLabelFromItemlist(),
being unable to handle several values.

This patch introduces a new method to avoid breaking compatibility.

Review

  • Code review CR +2
    • Francois Suter +2
    • Björn Pedersen +1
    • Markus Klein +1
  • Verified V +2
    • Francois Suter +2
    • Markus Klein +1

Issues 1

Files 1

Review log 23

  1. Francois Suter uploaded patch set 2 12/16/11, 13:12

  2. Francois Suter commented on patch set 2 12/16/11, 13:12

    New patch takes into account the whitespace/tab changes from merged version for TYPO3 4.5.
  3. Francois Suter uploaded patch set 3 12/16/11, 13:12

  4. Francois Suter commented on patch set 3 12/16/11, 13:12

    Patch set 3 addresses the comments. Please cast your vote again.
  5. Xavier Perseguers commented on patch set 1 12/16/11, 13:12

    Please see review in TYPO3_4-5 branch (I did not see it was for 4.5). And do not push patches to all branches until it is fully reviewed, this eases the review process.
  6. Xavier Perseguers commented on patch set 2 2 comments 12/16/11, 13:12

    Verified; I would prefer that you didn't submit this Thanks for this patch and the way you advertised it (screenshot). Please see inline comments to understand -1 on code review.
  7. Michael Stucki commented on patch set 4 12/16/11, 13:12

    Looks good to me, but someone else must approve Code review is fine but I haven't tested it yet.
  8. Michael Stucki uploaded patch set 5 12/16/11, 13:12

  9. Michael Stucki commented on patch set 5 12/16/11, 13:12

    Uploaded a new version which is rebased on the current master branch (otherwise I've been getting conflicts because of the linkvalidator submodule change). Someone please verify if I did this properly, thanks in advance...
  10. Francois Suter commented on patch set 5 V 0 12/16/11, 13:12

    by team member; Looks good to me, approved Well-test and reviewed across all branches.
  11. Björn Pedersen commented on patch set 5 12/16/11, 13:12

    Looks good to me, but someone else must approve
  12. Markus Klein commented on patch set 5 12/16/11, 13:12

    Verified; Looks good to me, but someone else must approve
  13. Xavier Perseguers uploaded patch set 4 12/16/11, 13:12

  14. Xavier Perseguers commented on patch set 4 12/16/11, 13:12

    Verified; Looks good to me, but someone else must approve
  15. Philipp Gampe commented on patch set 1 12/16/11, 13:12

    This patchset depends on an abondoned patchset.
  16. Mr. Jenkins commented on patch set 1 12/16/11, 13:12

    class.t3lib_befunc.php:1796

    Please use tabs

    class.t3lib_befunc.php:1805

    Please use tabs
  17. Mr. Jenkins commented on patch set 1 12/16/11, 13:12

    No score
  18. Mr. Jenkins commented on patch set 1 2 comments 12/16/11, 13:12

    Looks good to me, but someone else must approve Only some nitpicking. See the inline comments.
  19. Mr. Jenkins commented on patch set 2 12/16/11, 13:12

  20. Mr. Jenkins commented on patch set 3 12/16/11, 13:12

  21. Mr. Jenkins commented on patch set 4 12/16/11, 13:12

  22. Mr. Jenkins commented on patch set 5 12/16/11, 13:12

  23. Francois Suter merged patch set 5 12/16/11, 13:12