Review main Merged

63798[BUGFIX] Cast string to float in NumberViewHelper

Susi Moog CR +2 V +2 Easy +17 −1 updated 03/19/20, 16:28

Commit message

While number_format does an internal cast to float, it does not cast
things like empty strings to 0 - instead a PHP warning is emitted.

To catch that edge case, we are now casting to float before calling
number_format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Susi Moog uploaded patch set 1 03/19/20, 14:02

  2. Susi Moog uploaded patch set 2 03/19/20, 14:03

  3. TYPO3com voted on patch set 1 V +1 03/19/20, 14:15 Completed build in 12m 02s on Thu, 19 Mar, 02:15 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1450

  4. Georg Ringer voted on patch set 2 V +1 CR +1 03/19/20, 14:22

  5. TYPO3com voted on patch set 2 V +1 03/19/20, 14:23 Completed build in 17m 55s on Thu, 19 Mar, 02:23 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1451

  6. Guido Schmechel voted on patch set 2 CR +1 03/19/20, 15:13

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/19/20, 16:28

  8. Benni Mack merged patch set 3 03/19/20, 16:28