63799[BUGFIX] Update flag after drag&drop in Page module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LayoutModule/DragDrop.ts+20 −11
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+10 −2
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+6 −1
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js+1 −1
Review log 1215
-
Andreas Kienast uploaded patch set 1 03/19/20, 16:14
-
Andreas Kienast commented on patch set 1 CR -1 03/19/20, 16:22
Language title must get updated as well -
TYPO3com voted on patch set 1 V +1 03/19/20, 16:27 Completed build in 12m 13s on Thu, 19 Mar, 04:27 PM Test Summary: 72108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1457
-
Andreas Kienast uploaded patch set 2 03/19/20, 16:35
-
TYPO3com voted on patch set 2 V +1 03/19/20, 16:54 Completed build in 13m 51s on Thu, 19 Mar, 04:54 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1461
-
Benni Mack commented on patch set 2 03/19/20, 19:49
why do you want to backport this into 9.5. GridColumnItem does not exist in v9 AFAIK. -
Andreas Kienast commented on patch set 2 03/19/20, 19:53
> Patch Set 2: > > why do you want to backport this into 9.5. GridColumnItem does not exist in v9 AFAIK. The issue and PageLayoutView both exist in 9.5 ;) -
Susi Moog voted on patch set 2 CR +1 03/20/20, 06:51
-
Susi Moog voted on patch set 2 V +1 03/20/20, 07:01
-
Benni Mack commented on patch set 2 03/20/20, 10:44
I would go with master-only tbh. smells like this would break some "highly critical" extensions regarding page module ;) -
Andreas Kienast updated the commit message in patch set 3 03/20/20, 10:49
-
Susi Moog voted on patch set 3 V +1 CR +1 03/20/20, 11:13
-
TYPO3com voted on patch set 3 V +1 03/20/20, 11:24 Completed build in 29m 04s on Fri, 20 Mar, 11:24 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1491
-
Benni Mack voted on patch set 3 V +2 CR +2 03/20/20, 16:17
-
Benni Mack merged patch set 4 03/20/20, 16:17