Review main Merged

63802[TASK] Restructure phpstan configuration

Alexander Schnitzler CR +2 V +2 Normal +51 −10 updated 03/20/20, 11:05

Commit message

This patch simply pulls out the level 2 rules into
a separate configuration file which is a copy of the
original level 2 configuration file of phpstan with
some rules, services and parameters disabled.

Also, additional configuration files are put into the
Build folder and phpstan.neon has been added to the
.gitattributes file.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1115

  1. Alexander Schnitzler uploaded patch set 1 03/19/20, 17:50

  2. Alexander Schnitzler updated the commit message in patch set 2 03/19/20, 17:59

  3. Alexander Schnitzler wrote 03/19/20, 18:00

    Topic set to phpstan
  4. TYPO3com voted on patch set 1 V -1 03/19/20, 18:02 Completed build in 11m 44s on Thu, 19 Mar, 06:02 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1467

  5. Georg Ringer commented on patch set 2 CR -1 03/19/20, 18:08

    can we move those files into the build directory and pls add those files also to the .gitattributes file
  6. TYPO3com voted on patch set 2 V -1 03/19/20, 18:11 Completed build in 11m 38s on Thu, 19 Mar, 06:11 PM Test Summary: 61892 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1468

  7. Alexander Schnitzler commented on patch set 2 03/19/20, 18:19

    > Patch Set 2: Code-Review-1 > > can we move those files into the build directory and pls add those files also to the .gitattributes file Those files are temporary until we reach compatiblity with that mentioned level but yes, we can move them into Build.
  8. Alexander Schnitzler uploaded patch set 3 03/19/20, 18:29

  9. TYPO3com voted on patch set 3 V +1 03/19/20, 18:41 Completed build in 12m 17s on Thu, 19 Mar, 06:41 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1469

  10. Georg Ringer commented on patch set 3 CR -1 03/19/20, 20:41

    can we move also the phpstan.typo3.neon + phpstan.neon files and pls still add the entry point file to .gitattributes
  11. Alexander Schnitzler uploaded patch set 4 03/20/20, 09:42

  12. TYPO3com voted on patch set 4 V +1 03/20/20, 10:04 Completed build in 22m 23s on Fri, 20 Mar, 10:04 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1486

  13. Georg Ringer voted on patch set 4 V +1 CR +1 03/20/20, 10:52

  14. Alexander Schnitzler commented on patch set 4 V +2 CR +2 03/20/20, 11:05

    Got the permission to merge from Benni as it doesn't change functionality.
  15. Alexander Schnitzler merged patch set 5 03/20/20, 11:05