Review 9.5 Merged

63804[BUGFIX] Ask user for notifications before requesting permissions

Andreas Kienast CR +2 V +2 Easy +45 −5 updated 03/20/20, 07:18

Commit message

Since Firefox 72 a user interaction is required to prompt the user for native
browser notification permissions. This should prevent the user for
notification SPAM.

This patch introduces a modal confirmation, to get this user interaction.
The user is asked only once (as before), this is possible because the
modal is triggered only if a UC setting is not present.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 03/20/20, 06:32

  2. TYPO3com voted on patch set 1 V +1 03/20/20, 06:57 Completed build in 17m 39s on Fri, 20 Mar, 06:57 AM Test Summary: 74331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-279

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 03/20/20, 07:18

  4. Andreas Kienast merged patch set 2 03/20/20, 07:18