Review main Merged

63808[BUGFIX] Use string as hmac context in inline controllers

Andreas Kienast CR +2 V +2 Normal +47 −49 updated 03/21/20, 08:40

Commit message

The order in JSON objects is not defined and the browser can stringify
them in an arbitrary order.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 57

  1. Andreas Kienast uploaded patch set 1 03/20/20, 08:53

  2. TYPO3com voted on patch set 1 V -1 03/20/20, 09:13 Completed build in 20m 13s on Fri, 20 Mar, 09:13 AM Test Summary: 1 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1485

  3. TYPO3com voted on patch set 1 V +1 03/20/20, 09:29 Completed build in 55m 33s on Fri, 20 Mar, 09:29 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1485

  4. Susi Moog voted on patch set 1 CR +1 03/20/20, 13:19

  5. Susi Moog voted on patch set 1 V +1 03/21/20, 07:55

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 03/21/20, 08:39

  7. Anja Leichsenring merged patch set 2 03/21/20, 08:40