Review main Merged

63811[BUGFIX] React on delete actions via context menu

Andreas Kienast CR +2 V +2 Normal +115 −14 updated 09/04/20, 13:37

Commit message

If a record gets deleted via context menu no further handling could be
added as the promise returned by AjaxDataHandler is available in an
encapsulated scope only.

To bypass this issue, the AjaxDataHandler now optionally emits events to
listen on. This patch implements event listeners for the record list and
the information module of "Template tools".

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 810

  1. Andreas Kienast uploaded patch set 1 03/20/20, 11:37

  2. TYPO3com voted on patch set 1 V +1 03/20/20, 12:09 Completed build in 18m 22s on Fri, 20 Mar, 12:09 PM Test Summary: 72118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1494

  3. Susi Moog updated the commit message in patch set 2 03/21/20, 08:40

  4. Susi Moog voted on patch set 2 V +1 CR +1 03/21/20, 08:44

  5. TYPO3com voted on patch set 2 V +1 03/21/20, 09:22 Completed build in 39m 49s on Sat, 21 Mar, 09:22 AM Test Summary: 72163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1530

  6. Anja Leichsenring commented on patch set 2 V +2 CR +2 03/21/20, 09:28

    nice improvement, thank you!
  7. Anja Leichsenring merged patch set 3 03/21/20, 09:28

  8. Oliver Hader commented on patch set 3 09/03/20, 06:45

    AjaxDataHandler.ts:98

    Just stumbled over this one... what does it mean, what is actually better/different in Recordlist.ts?
  9. Oliver Hader commented on patch set 3 09/03/20, 06:55

    AjaxDataHandler.ts:98 Reply

    I added `(extract visual/DOM-related parts to Recordlist or any other new component; keep processing flow in this class)` in my local working copy - at least it's how I understood it, correct?
  10. Andreas Kienast commented on patch set 3 09/04/20, 13:37

    AjaxDataHandler.ts:98 Reply Unresolved

    Yes, thanks. The issue right now is that AjaxDataHandler also cares about UI state which should be extracted to RecordList or anything else re-usable.