63811[BUGFIX] React on delete actions via context menu
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts3+28 −9
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts+2 −1
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Recordlist.ts+40 −1
- Build/Sources/TypeScript/tstemplate/Resources/Public/TypeScript/InformationModule.tsnew+28 −0
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/InformationModule.html+1 −0
- typo3/sysext/tstemplate/Resources/Public/JavaScript/InformationModule.jsnew+13 −0
Review log 810
-
Andreas Kienast uploaded patch set 1 03/20/20, 11:37
-
TYPO3com voted on patch set 1 V +1 03/20/20, 12:09 Completed build in 18m 22s on Fri, 20 Mar, 12:09 PM Test Summary: 72118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1494
-
Susi Moog updated the commit message in patch set 2 03/21/20, 08:40
-
Susi Moog voted on patch set 2 V +1 CR +1 03/21/20, 08:44
-
TYPO3com voted on patch set 2 V +1 03/21/20, 09:22 Completed build in 39m 49s on Sat, 21 Mar, 09:22 AM Test Summary: 72163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1530
-
Anja Leichsenring commented on patch set 2 V +2 CR +2 03/21/20, 09:28
nice improvement, thank you! -
Anja Leichsenring merged patch set 3 03/21/20, 09:28
-
Oliver Hader commented on patch set 3 09/03/20, 06:45
AjaxDataHandler.ts:98Just stumbled over this one... what does it mean, what is actually better/different in Recordlist.ts? -
Oliver Hader commented on patch set 3 09/03/20, 06:55
AjaxDataHandler.ts:98ReplyI added `(extract visual/DOM-related parts to Recordlist or any other new component; keep processing flow in this class)` in my local working copy - at least it's how I understood it, correct? -
Andreas Kienast commented on patch set 3 09/04/20, 13:37
AjaxDataHandler.ts:98Reply UnresolvedYes, thanks. The issue right now is that AjaxDataHandler also cares about UI state which should be extracted to RecordList or anything else re-usable.