Review main Merged

63812[TASK] Enable phpstan rules up to level 8

Alexander Schnitzler CR +2 V +2 Hard +265 −1 updated 03/20/20, 17:18

Commit message

As there are a lot of rules that do not raise any errors
with our code base, those rules up to level 8 are enabled
with this patch resulting in more pre merge tests being
executed as of now.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 03/20/20, 12:28

  2. Alexander Schnitzler updated the commit message in patch set 2 03/20/20, 12:43

  3. TYPO3com voted on patch set 1 V +1 03/20/20, 12:43 Completed build in 15m 26s on Fri, 20 Mar, 12:43 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1495

  4. TYPO3com voted on patch set 2 V +1 03/20/20, 12:55 Completed build in 12m 19s on Fri, 20 Mar, 12:55 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1496

  5. Alexander Schnitzler wrote 03/20/20, 13:01

    Topic set to phpstan
  6. Daniel Goerz voted on patch set 2 V +1 CR +1 03/20/20, 16:51

  7. Andreas Kienast commented on patch set 2 V +2 CR +2 03/20/20, 17:18

    Verified by Bamboo
  8. Andreas Kienast merged patch set 3 03/20/20, 17:18