Review main Merged

63813[BUGFIX] Avoid errors for creating new IRRE Elements on new parent records

Benni Mack CR +2 V +2 Easy +8 −6 updated 03/21/20, 09:05

Commit message

This happens when the content element does not exist yet, which
is why this needs to be checked properly, otherwise the PHP strict
typing error will stop execution of the PHP script.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 03/20/20, 12:45

  2. TYPO3com voted on patch set 1 V +1 03/20/20, 13:00 Completed build in 14m 54s on Fri, 20 Mar, 01:00 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1497

  3. Benni Mack updated the commit message in patch set 2 03/21/20, 07:50

  4. TYPO3com voted on patch set 2 V +1 03/21/20, 08:11 Completed build in 18m 22s on Sat, 21 Mar, 08:11 AM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1529

  5. Susi Moog voted on patch set 2 V +1 CR +1 03/21/20, 08:27

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/21/20, 09:05

  7. Anja Leichsenring merged patch set 3 03/21/20, 09:05