63815[BUGFIX] Do not stop indexing on errors
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Susi Moog uploaded patch set 1 03/20/20, 13:16
-
TYPO3com voted on patch set 1 V +1 03/20/20, 13:32 Completed build in 16m 05s on Fri, 20 Mar, 01:32 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1501
-
Daniel Goerz commented on patch set 1 03/20/20, 16:50
-
Susi Moog uploaded patch set 2 03/21/20, 07:18
-
TYPO3com voted on patch set 2 V -1 03/21/20, 07:37 Completed build in 18m 54s on Sat, 21 Mar, 07:37 AM Test Summary: 9 of 72607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1527
-
Susi Moog commented on patch set 2 03/21/20, 07:56
Indexer.php:274Reply Unresolvedit could. -
TYPO3com voted on patch set 2 V +1 03/21/20, 08:06 Completed build in 1h 07m 02s on Sat, 21 Mar, 08:06 AM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1527
-
Benni Mack voted on patch set 2 CR +1 03/22/20, 12:26
-
Andreas Kienast voted on patch set 2 CR +1 03/22/20, 12:32
-
Benni Mack voted on patch set 2 V +1 03/22/20, 19:03
-
Alexander Schnitzler commented on patch set 2 03/22/20, 20:13
Indexer.php:273Shouldn't this be \Throwable instead of \Exception? -
Susi Moog commented on patch set 2 03/23/20, 12:12
Indexer.php:273Reply UnresolvedIn case of an exception it's fine to continue, as the severity of throwable in this case is higher, I used \Exception on purpose. -
Andreas Kienast voted on patch set 2 V +2 CR +2 03/24/20, 07:24
-
Andreas Kienast merged patch set 3 03/24/20, 07:24
Indexer.php:274