Review main Merged

63816[BUGFIX] Properly merge RequireJS configuration

Andreas Kienast CR +2 V +2 Normal +54 −1 updated 03/20/20, 15:58

Commit message

If PageRenderer->addRequireJsConfiguration() is consecutively called,
the configuration is now properly merged by using
array_merge_recursive(). The previously used
ArrayUtility::mergeRecursiveWithOverrule() overrode any previously set
keys of the numeric array which broke the configuration.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 03/20/20, 13:56

  2. TYPO3com voted on patch set 1 V -1 03/20/20, 14:07 Completed build in 11m 11s on Fri, 20 Mar, 02:07 PM Test Summary: 71812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1503

  3. TYPO3com voted on patch set 1 V +1 03/20/20, 14:11 Completed build in 26m 39s on Fri, 20 Mar, 02:11 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1503

  4. Susi Moog voted on patch set 1 CR +1 03/20/20, 14:16

  5. Susi Moog voted on patch set 1 V +1 03/20/20, 14:17

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 03/20/20, 15:57

  7. Daniel Goerz merged patch set 2 03/20/20, 15:58