Review main Merged

63818[BUGFIX] Never show failed "ADMCMD expired" exception

Benni Mack CR +2 V +2 Easy +4 −3 updated 03/20/20, 16:42

Commit message

If somebody calls www.example.com?AMDCMD_prev=abcbenni the output
should never throw an exception (also if the preview entry or the
cookie has expired).

The cookie itself is a session-based cookie nowadays, so the expiration
of the cookie is not relevant.

The change lets outsiders just fall back silently to the Live version.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 03/20/20, 15:27

  2. Benni Mack updated the commit message in patch set 2 03/20/20, 15:29

  3. Susi Moog voted on patch set 2 V +1 CR +1 03/20/20, 15:31

  4. TYPO3com voted on patch set 1 V -1 03/20/20, 15:39 Completed build in 11m 05s on Fri, 20 Mar, 03:39 PM Test Summary: 71798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1508

  5. TYPO3com voted on patch set 2 V +1 03/20/20, 15:44 Completed build in 15m 19s on Fri, 20 Mar, 03:44 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1509

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 03/20/20, 16:42

  7. Daniel Goerz merged patch set 3 03/20/20, 16:42