Review main Merged

6382[BUGFIX] Install Tool: Improper check of PHP session.auto_start

Markus Klein CR +2 V +2 Easy +10 −1 updated 06/03/13, 20:49

Commit message

This fix improves the check for the PHP session.auto_start configuration
to account also for valid Yes/No configuration values.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Xavier Perseguers +2
    • Georg Ringer +1

Files 2

Review log 9

  1. Stefan Neufeind commented on patch set 2 11/22/11, 14:08

    Looks good to me, but someone else must approve
  2. Markus Klein uploaded patch set 2 11/22/11, 14:08

  3. Markus Klein commented on patch set 2 11/22/11, 14:08

    Repushed because of unwanted (sudden?) dependency.
  4. Xavier Perseguers commented on patch set 1 11/22/11, 14:08

    Looks good to me, but someone else must approve
  5. Xavier Perseguers commented on patch set 2 V 0 11/22/11, 14:08

    by team member; Looks good to me, approved
  6. Georg Ringer commented on patch set 2 11/22/11, 14:08

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 11/22/11, 14:08

  8. Mr. Jenkins commented on patch set 2 11/22/11, 14:08

  9. Xavier Perseguers merged patch set 2 11/22/11, 14:08