Review main Merged

63820[TASK] Avoid creation of ClassSchema instances

Alexander Schnitzler CR +2 V +2 Easy +1 −1 updated 03/20/20, 18:44

Commit message

The extbase container provides a method isSingleton that
checks if a class implements the SingletonInterface interface.

It did so by creating a ClassSchema instance for the given
class name which is not needed as there are more efficient
ways to check for implemented interfaces that don't require
the creation of a ClassSchema instance.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 03/20/20, 16:06

  2. Alexander Schnitzler wrote 03/20/20, 16:16

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 03/20/20, 16:22 Completed build in 16m 32s on Fri, 20 Mar, 04:22 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1512

  4. Alexander Schnitzler updated the commit message in patch set 2 03/20/20, 17:04

  5. Oliver Klee voted on patch set 2 CR +1 03/20/20, 17:05

  6. TYPO3com voted on patch set 2 V +1 03/20/20, 17:15 Completed build in 11m 37s on Fri, 20 Mar, 05:15 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1517

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 03/20/20, 17:16

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/20/20, 18:44

  9. Benni Mack merged patch set 3 03/20/20, 18:44