Review main Merged Breaking

63821[!!!][TASK] Remove non-public extbase property injection

Alexander Schnitzler CR +2 V +2 Normal +72 −25 updated 06/03/20, 09:51

Commit message

The property injection with non-public properties had been
deprecated with #82975 and has been forgotten to be removed
until now. With this patch only public properties can be
used for extbase dependency injection.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1623

  1. Alexander Schnitzler uploaded patch set 1 03/20/20, 16:11

  2. Alexander Schnitzler wrote 03/20/20, 16:16

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 03/20/20, 16:26 Completed build in 13m 39s on Fri, 20 Mar, 04:26 PM Test Summary: 6 of 72607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1513

  4. Daniel Goerz commented on patch set 1 03/20/20, 17:10

    Shouldn't already trigger a deprecation error since https://review.typo3.org/c/Packages/TYPO3.CMS/+/54618
  5. Alexander Schnitzler uploaded patch set 2 03/20/20, 18:06

  6. Alexander Schnitzler commented on patch set 2 03/20/20, 18:08

    > Patch Set 1: > > Shouldn't already trigger a deprecation error since https://review.typo3.org/c/Packages/TYPO3.CMS/+/54618 lol, i missed that.
  7. TYPO3com voted on patch set 2 V +1 03/20/20, 18:17 Completed build in 11m 07s on Fri, 20 Mar, 06:17 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1520

  8. Alexander Schnitzler uploaded patch set 3 03/20/20, 18:25

  9. TYPO3com voted on patch set 3 V -1 03/20/20, 18:40 Completed build in 14m 46s on Fri, 20 Mar, 06:40 PM Test Summary: 426 of 72601 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1522

  10. Georg Ringer commented on patch set 3 CR -1 03/21/20, 19:31

    is #54618 really the
    is this really the correct issue? I doubt
  11. Alexander Schnitzler commented on patch set 3 03/21/20, 19:48

    Reply Unresolved

    Thanks for the catch. This issue is postponed until 11.0 anyway. I will take care about this in a couple of weeks.
  12. Alexander Schnitzler uploaded patch set 4 06/03/20, 08:11

  13. Alexander Schnitzler commented on patch set 4 06/03/20, 08:13

    This change is ready for review.
  14. TYPO3com voted on patch set 4 V -1 06/03/20, 08:23 Completed build in 12m 01s on Wed, 3 Jun, 08:23 AM Test Summary: 426 of 73323 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3762

  15. Benjamin Franzke uploaded patch set 5 06/03/20, 08:33

  16. Alexander Schnitzler uploaded patch set 6 06/03/20, 08:53

  17. TYPO3com voted on patch set 5 V -1 06/03/20, 09:02 Completed build in 18m 31s on Wed, 3 Jun, 09:02 AM Test Summary: 354 of 73323 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3763

  18. TYPO3com voted on patch set 6 V +1 06/03/20, 09:24 Completed build in 25m 26s on Wed, 3 Jun, 09:24 AM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3766

  19. Alexander Schnitzler commented on patch set 6 CR -1 06/03/20, 09:28

    Needs the changes of patch set 5 reapplied.
  20. Benjamin Franzke uploaded patch set 7 06/03/20, 09:30

  21. TYPO3com voted on patch set 7 V +1 06/03/20, 09:47 Completed build in 13m 30s on Wed, 3 Jun, 09:47 AM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3770

  22. Benni Mack voted on patch set 7 V +2 CR +2 06/03/20, 09:51

  23. Benni Mack merged patch set 8 06/03/20, 09:51