Review main Merged

63822[BUGFIX] Move non-build dependencies into `dependencies`

Andreas Kienast CR +2 V +2 Normal +27 −27 updated 03/21/20, 13:30

Commit message

To have a better overview of which packages are actually in TYPO3
itself, matching packages have been moved into the `dependencies` section
of package.json.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Andreas Kienast uploaded patch set 1 03/20/20, 17:14

  2. Georg Ringer voted on patch set 1 V +1 CR +1 03/20/20, 17:15

  3. TYPO3com voted on patch set 1 V +1 03/20/20, 17:28 Completed build in 13m 45s on Fri, 20 Mar, 05:28 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1518

  4. Oliver Hader voted on patch set 1 CR +1 03/20/20, 17:53

  5. Oliver Hader commented on patch set 1 03/20/20, 17:54

    Could we do that for TYPO3 v9 as well? I guest it would not be breaking, correct?
  6. Andreas Kienast commented on patch set 1 03/20/20, 18:23

    > Patch Set 1: > > Could we do that for TYPO3 v9 as well? I guest it would not be breaking, correct? I'm fine with that. The only thing we have to consider is that backporting this very patch doesn't make much sense, I'd create a backport manually.
  7. Andreas Kienast updated the commit message in patch set 2 03/20/20, 18:23

  8. TYPO3com voted on patch set 2 V +1 03/20/20, 18:34 Completed build in 11m 12s on Fri, 20 Mar, 06:34 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1521

  9. Daniel Haupt voted on patch set 2 V +1 CR +1 03/20/20, 18:47

  10. Georg Ringer voted on patch set 2 V +1 CR +1 03/20/20, 18:55

  11. Susi Moog voted on patch set 2 V +1 CR +1 03/21/20, 08:35

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 03/21/20, 08:39

  13. Andreas Kienast merged patch set 3 03/21/20, 08:39

  14. Oliver Hader voted on patch set 3 CR +1 03/21/20, 13:30