Review main Merged

63823[BUGFIX] Allow file links to files with anchors

Benni Mack CR +2 V +2 Normal +69 −27 updated 03/21/20, 09:20

Commit message

When creating a link with TypoLink or Fluid pointing to a file,
it is possible (e.g. in PDFs) to use an "anchor" (#) to point to a specific
section.

This is now possible like this:
<f:link.typolink parameter="file:1#page-13">test</f:link.typolink>

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 57

  1. Benni Mack uploaded patch set 1 03/20/20, 19:19

  2. TYPO3com voted on patch set 1 V -1 03/20/20, 19:30 Completed build in 10m 41s on Fri, 20 Mar, 07:30 PM Test Summary: 12 of 72667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1523

  3. Benni Mack uploaded patch set 2 03/20/20, 19:45

  4. TYPO3com voted on patch set 2 V +1 03/20/20, 19:55 Completed build in 10m 50s on Fri, 20 Mar, 07:55 PM Test Summary: 72183 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1524

  5. Susi Moog voted on patch set 2 V +1 CR +1 03/21/20, 08:34

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/21/20, 09:20

  7. Anja Leichsenring merged patch set 3 03/21/20, 09:20