Review main Merged

63829[BUGFIX] Remove mention of deprecation log in presets

Susi Moog CR +2 V +2 Easy +2 −2 updated 03/25/20, 10:20

Commit message

The debug/live presets toggled the deprecation log in earlier versions.
Since rewriting the deprecation log to the logging framework, the
presets do not take deprecations into account anymore. Due to the
configuration merge between Default and LocalConfiguration it is
currently not possible to disable the deprecation log by overwriting
it in LocalConfiguration - setting will only take effect when set in
AdditionalConfiguration. Therefor we are removing the mention of
deprecation logs in the presets to avoid confusion.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Susi Moog uploaded patch set 1 03/21/20, 16:03

  2. TYPO3com voted on patch set 1 V +1 03/21/20, 16:16 Completed build in 12m 31s on Sat, 21 Mar, 04:16 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1546

  3. Benni Mack voted on patch set 1 CR +1 03/21/20, 18:46

  4. Daniel Haupt commented on patch set 1 V -1 03/22/20, 14:23

    Although the configuration in LocalConfiguration.php seems to be correct, in my instance (latest master) the LivePreset still creates a deprection log. Looking into ext:lowlevel confirms that the configuration is not applied.

    DebugPreset.php:46 Unresolved

    Nit: Should we keep the alphabetical order and put this line after 'FE/debug' => true?
  5. Susi Moog commented on patch set 1 V -1 03/23/20, 06:48

    Daniel is right - it's because you actually cannot overwrite the log settings in local configuration if the base is defined in DefaultConfiguration. This only works in AdditionalConfiguration (which is user land and therefor "none of our business") - tbh I have no idea how to fix this issue.
  6. Susi Moog abandoned the change 03/25/20, 09:54

  7. Susi Moog restored the change 03/25/20, 09:55

  8. Susi Moog uploaded patch set 2 03/25/20, 09:58

  9. TYPO3com voted on patch set 2 V +1 03/25/20, 10:10 Completed build in 11m 30s on Wed, 25 Mar, 10:10 AM Test Summary: 73017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1697

  10. Georg Ringer voted on patch set 2 V +1 CR +1 03/25/20, 10:11

  11. Daniel Haupt voted on patch set 2 V +1 CR +1 03/25/20, 10:18

  12. Benni Mack voted on patch set 2 V +2 CR +2 03/25/20, 10:20

  13. Benni Mack merged patch set 3 03/25/20, 10:20